Repository navigation
Commit 19245e4
committed
fix(apply): preflight resolves nodes from talosconfig when --nodes omitted
Address review feedback from coderabbitai on
pkg/commands/apply.go:178: the direct-patch closure iterated
GlobalArgs.Nodes only, but wrapWithNodeContext fills ctx via
client.WithNodes from the talosconfig context when --nodes is omitted
without mutating GlobalArgs.Nodes itself. The preflight loop was a
no-op in that path and the log line printed an empty node list.
Mirror wrapWithNodeContext's resolution into a local targetNodes
slice and use it for both the log line and the per-node preflight
loop. With --nodes set, behavior is unchanged.
Assisted-By: Claude <[email protected]>
Signed-off-by: Aleksei Sviridkin <[email protected]>1 parent b6e0618 commit 19245e4
1 file changed
Lines changed: 13 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
171 | | - | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
172 | 182 | | |
173 | | - | |
174 | | - | |
| 183 | + | |
175 | 184 | | |
176 | 185 | | |
177 | 186 | | |
178 | | - | |
| 187 | + | |
179 | 188 | | |
180 | 189 | | |
181 | 190 | | |
| |||
0 commit comments