Skip to content
This repository was archived by the owner on Oct 10, 2026. It is now read-only.

Commit 0338e19

Browse files
committed
ci(workflows): refresh CI for Go 1.26 and k8s 0.36
The fork now builds against Go 1.26 and client-go 0.36, which makes the CI pipeline that shipped with the upstream repository unusable: * golangci-lint v1.61 predates Go 1.26 and rejects the toolchain. Bump to v2.12.2 with the matching golangci/golangci-lint-action@v9 (v2 requires the action's major version 9 or newer). * The integration-test matrix targeted Kubernetes 1.29/1.30/1.31. With client-go 0.36, the WatchListClient feature gate is enabled by default, and against API servers older than 1.36 the initial events stream never delivers the BOOKMARK event the client waits for — informers hang on cache sync until the job times out. Bump the matrix to 1.34.8 / 1.35.5 / 1.36.1 (current supported releases) and pass KUBE_FEATURE_WatchListClient=false to the integration-test step so older API servers in the matrix still pass. * Refresh setup-minikube, setup-helm, setup-go, and actions/checkout to their current major versions; bump the helm CLI used by the chart-test job to v3.21.0. Release Charts workflow gets the same setup-helm/checkout/helm CLI bumps plus chart-releaser-action v1.7.0 so it keeps releasing chart artefacts after the toolchain upgrade. Signed-off-by: Arsolitt <[email protected]>
1 parent 3c81126 commit 0338e19

2 files changed

Lines changed: 26 additions & 19 deletions

File tree

‎.github/workflows/ci.yaml‎

Lines changed: 22 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,22 @@ jobs:
1111
name: Golang Check
1212
runs-on: ubuntu-latest
1313
steps:
14-
- uses: actions/checkout@v4
15-
- uses: actions/setup-go@v5
14+
- uses: actions/checkout@v6
15+
- uses: actions/setup-go@v6
1616
with:
1717
go-version-file: go.mod
1818
cache: false
1919
- name: golangci-lint
20-
uses: golangci/golangci-lint-action@v6
20+
uses: golangci/golangci-lint-action@v9
2121
with:
22-
version: v1.61
23-
args: --timeout=15m
22+
version: v2.12.2
2423

2524
unit-test:
2625
name: Unit test
2726
runs-on: ubuntu-latest
2827
steps:
29-
- uses: actions/checkout@v4
30-
- uses: actions/setup-go@v5
28+
- uses: actions/checkout@v6
29+
- uses: actions/setup-go@v6
3130
with:
3231
go-version-file: go.mod
3332
- run: make ci-unit-test
@@ -38,34 +37,42 @@ jobs:
3837
needs: [check, unit-test]
3938
strategy:
4039
matrix:
41-
kubernetes: [1.29.10, 1.30.6, 1.31.2]
40+
kubernetes: [1.34.8, 1.35.5, 1.36.1]
4241
steps:
43-
- uses: actions/checkout@v4
44-
- uses: actions/setup-go@v5
42+
- uses: actions/checkout@v6
43+
- uses: actions/setup-go@v6
4544
with:
4645
go-version-file: go.mod
4746
- name: Install conntrack
4847
run: sudo apt-get install --yes conntrack
49-
- uses: medyagh/[email protected].18
48+
- uses: medyagh/[email protected].21
5049
with:
5150
kubernetes-version: ${{ matrix.kubernetes }}
5251
driver: none
5352
- name: Add redisfailover CRD
5453
run: kubectl create --filename manifests/databases.spotahome.com_redisfailovers.yaml
55-
- run: make ci-integration-test
54+
- name: Run integration tests
55+
env:
56+
# client-go 0.36 ships WatchListClient enabled by default. On Kubernetes
57+
# API servers < 1.36 the initial events stream never delivers the
58+
# required BOOKMARK event, so informers hang forever on cache sync.
59+
# Disable the feature gate from the client side to keep the matrix
60+
# green across all supported server versions.
61+
KUBE_FEATURE_WatchListClient: "false"
62+
run: make ci-integration-test
5663

5764
chart-test:
5865
name: Chart testing
5966
runs-on: ubuntu-latest
6067
steps:
61-
- uses: actions/checkout@v4
68+
- uses: actions/checkout@v6
6269
with:
6370
fetch-depth: 0
6471

6572
- name: Install Helm
66-
uses: azure/setup-helm@v4
73+
uses: azure/setup-helm@v5
6774
with:
68-
version: v3.15.4
75+
version: v3.21.0
6976

7077
- name: Helm test
7178
run: make helm-test

‎.github/workflows/helm.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
release:
1010
runs-on: ubuntu-latest
1111
steps:
12-
- uses: actions/checkout@v3
12+
- uses: actions/checkout@v6
1313
with:
1414
fetch-depth: 0
1515
- name: Configure Git
@@ -18,12 +18,12 @@ jobs:
1818
git config user.email "${GITHUB_ACTOR}@users.noreply.github.com"
1919
2020
- name: Install Helm
21-
uses: azure/setup-helm@v3
21+
uses: azure/setup-helm@v5
2222
with:
23-
version: v3.7.2
23+
version: v3.21.0
2424

2525
- name: Release
26-
uses: helm/chart-releaser-action@v1.5.0
26+
uses: helm/chart-releaser-action@v1.7.0
2727
with:
2828
charts_dir: charts
2929
config: charts/chart-release-config.yaml

0 commit comments

Comments
 (0)