Repository navigation
fix(controller): install rocks by URL, bypassing the luarocks index - #6
Merged
Merged
Conversation
The controller image has not built since March. Every attempt dies on
luarocks install lua-protobuf 0.4.1-1
Error: No results matching query were found.
which reads like the rock was withdrawn. It was not: 0.4.1-1 is still
published, and the same failure hits lua-iconv and every other query.
The cause is upstream of us. luarocks resolves a name through the
luarocks.org index, and that index has grown past what LuaJIT can
compile:
Failed loading manifest for https://luarocks.org/...:
main function has more than 65536 constants
65536 constants per function is a hard LuaJIT limit, so no client can
load the index any more and every lookup returns nothing. Nothing here
rotted; the ecosystem moved out from under a Dockerfile that had been
fine for years, which is why the build broke with no commit to blame.
Bumping LUA_ROCKS_VER does not help — 3.11.1 fails identically. Nor does
swapping busybox wget for GNU wget, though that difference is real:
luarocks invokes wget with --no-cache, --tries and --timestamping, none
of which busybox supports. Fixing that only changes the error message.
Installing from a rockspec URL skips the index entirely, which is the
actual fix. Two things follow from it:
* git joins the build deps, because the rockspecs fetch their sources
from git rather than a tarball.
* lua-iconv moves from 7-3 to 7.1.0-1. The 7-3 rockspec points at
github.com/downloads/ittner/lua-iconv/..., and GitHub removed the
/downloads/ scheme years ago, so that version cannot be fetched by
anyone regardless of the index. 7.1.0-1 builds from a live git tag.
Verified in registry.k8s.io/ingress-nginx/controller:v1.11.5, the image
this Dockerfile builds on: both rocks install.
Note that merging this rebuilds nothing on its own. The workflow fires
on tag pushes and names the image after the tag, so v1.11.5 has to be
re-pointed at the fixed commit before a working controller:v1.11.5
exists.
Signed-off-by: Andrei Kvapil <[email protected]>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
myasnikovdaniil
marked this pull request as ready for review
August 25, 2026 13:20
Andrei Kvapil (kvaps)
added a commit
to cozystack/cozystack
that referenced
this pull request
Aug 25, 2026
The controller digest this pinned was a build dated 2025-03-26, whose
nginx.tmpl calls buildHTTP3Listener — a function no v1.11.5 binary
defines. Go binds template functions at parse time, so the
{{ if $cfg.UseHTTP3 }} guard around it does not help and the controller
crash-loops on a default config, serving no webhook at all.
The tag pointed at that image because the controller had not been built
since March: the build in the fork failed on a luarocks step, and the
cause was outside the repository. luarocks resolves a rock name through
the luarocks.org index, and that index has grown past LuaJIT's hard
limit of 65536 constants per function, so no client can load it and
every lookup returns "No results matching query were found". Neither a
luarocks bump nor GNU wget fixes that; installing from a rockspec URL,
which skips the index, does. Fixed in
cozystack/ingress-nginx-with-protobuf-exporter#6 and the v1.11.5 tag
re-pointed at it.
Verified in the rebuilt image: zero references to buildHTTP3Listener,
and both lua-protobuf and lua-iconv present — the rocks this fork exists
to add.
The exporter is re-pinned in the same commit rather than separately. It
had drifted a build ahead of its tag before this rebuild, and refreshing
one half alone would leave the PR looking updated while the controller
was still the March build.
Signed-off-by: Andrei Kvapil <[email protected]>
Merged
1 of 11 tasks
Andrei Kvapil (kvaps)
added a commit
to cozystack/cozystack
that referenced
this pull request
Sep 7, 2026
The controller digest this pinned was a build dated 2025-03-26, whose
nginx.tmpl calls buildHTTP3Listener — a function no v1.11.5 binary
defines. Go binds template functions at parse time, so the
{{ if $cfg.UseHTTP3 }} guard around it does not help and the controller
crash-loops on a default config, serving no webhook at all.
The tag pointed at that image because the controller had not been built
since March: the build in the fork failed on a luarocks step, and the
cause was outside the repository. luarocks resolves a rock name through
the luarocks.org index, and that index has grown past LuaJIT's hard
limit of 65536 constants per function, so no client can load it and
every lookup returns "No results matching query were found". Neither a
luarocks bump nor GNU wget fixes that; installing from a rockspec URL,
which skips the index, does. Fixed in
cozystack/ingress-nginx-with-protobuf-exporter#6 and the v1.11.5 tag
re-pointed at it.
Verified in the rebuilt image: zero references to buildHTTP3Listener,
and both lua-protobuf and lua-iconv present — the rocks this fork exists
to add.
The exporter is re-pinned in the same commit rather than separately. It
had drifted a build ahead of its tag before this rebuild, and refreshing
one half alone would leave the PR looking updated while the controller
was still the March build.
Signed-off-by: Andrei Kvapil <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The controller image has not built since March. Every attempt dies on
luarocks install lua-protobuf 0.4.1-1withError: No results matching query were found., which reads like the rock was withdrawn — it was not.0.4.1-1is still published, and the same failure hitslua-iconvand every other query.The cause is upstream of this repo. luarocks resolves a name through the luarocks.org index, and that index has grown past what LuaJIT can compile:
65536 constants per function is a hard LuaJIT limit, so no client can load the index any more and every lookup returns nothing. Nothing here rotted — the ecosystem moved out from under a Dockerfile that had been fine for years, which is why the build broke with no commit to blame and stayed broken quietly.
What was ruled out first
LUA_ROCKS_VER. 3.11.1 fails identically to 3.0.0. The newer client just reports it better.--no-cache,--triesand--timestamping, none of which busybox supports — but fixing it only changes the error message, because the index still cannot be loaded.The fix
Installing from a rockspec URL skips the index entirely. Two things follow:
gitjoins the build deps, because the rockspecs fetch their sources from git rather than a source tarball.lua-iconvmoves from7-3to7.1.0-1. The7-3rockspec points atgithub.com/downloads/ittner/lua-iconv/..., and GitHub removed the/downloads/scheme years ago, so that version is unfetchable by anyone regardless of the index.7.1.0-1builds from a live git tag.Verified in
registry.k8s.io/ingress-nginx/controller:v1.11.5, the image this Dockerfile builds on: both rocks install.What this does not do
Merging this rebuilds nothing. The workflow fires on tag pushes and names the image after the tag, so
v1.11.5has to be re-pointed at the fixed commit before a workingcontroller:v1.11.5exists.That matters downstream:
controller:v1.11.5currently resolves to a build dated 2025-03-26, whosenginx.tmplcallsbuildHTTP3Listener— a function no v1.11.5 binary defines. Go binds template functions at parse time, so the{{ if $cfg.UseHTTP3 }}guard does not help and the controller crash-loops on a default config. cozystack/cozystack#3798 pins that digest and is blocked on it.