Repository navigation

Commit e92faec

committed

fix(scripts): make .PHONY in package.mk an actual declaration

Line 2 used `.PHONY=`, which is a variable assignment. Make defined a variable that nothing reads, and none of the listed targets was phony. The special target needs a colon. Line 1 is `.DEFAULT_GOAL=help`, a real variable where `=` is correct, which is likely why this went unnoticed. Corrected the list to what this file actually defines. `suspend`, `resume`, `check` and `clean` were missing; `check` is the prerequisite that keeps `show`, `diff`, `apply` and `delete` rebuilding. Dropped `update` and `image`, which are defined neither here nor in any package Makefile: naming an undefined target in `.PHONY` creates it empty, so `make image` would report nothing to be done and exit 0 instead of failing with "No rule to make target". Assisted-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>

1 parent 1e778fb commit e92faecCopy full SHA for e92faec

1 file changed

scripts
- package.mk

`‎scripts/package.mk‎`

-Original file line number
+Diff line change
@@ @@ -1,5 +1,5 @@ @@
 .DEFAULT_GOAL=help
 -.PHONY=help show diff apply delete update image
 +.PHONY: help show diff apply delete suspend resume check clean
 help: ## Show this help.
 	@awk 'BEGIN {FS = ":.*?## "} /^[a-zA-Z_-]+:.*?## / {sub("\\\\n",sprintf("\n%22c"," "), $$2);printf "\033[36m%-20s\033[0m %s\n", $$1, $$2}' $(MAKEFILE_LIST)

Comments

(0)