Repository navigation
enh: Update status in reconcile loop, not in defer - #41
Merged
Kirill Ilin (sircthulhu) merged 3 commits intoMar 20, 2024
Merged
Conversation
Kirill Ilin (sircthulhu)
added
ok-to-test
Sergey Shevchenko (sergeyshevch)
suggested changes
Mar 19, 2024
Kirill Ilin (sircthulhu)
force-pushed
the
enhancement/36-update-status-outside-defer
branch
from
March 20, 2024 05:56
bb3904b to
e8d85c1
Compare
Kirill Ilin (sircthulhu)
requested a review
from Sergey Shevchenko (sergeyshevch)
March 20, 2024 06:01
Sergey Shevchenko (sergeyshevch)
approved these changes
Mar 20, 2024
Kirill Ilin (sircthulhu)
enabled auto-merge (squash)
March 20, 2024 16:46
Kirill Ilin (sircthulhu)
deleted the
enhancement/36-update-status-outside-defer
branch
March 20, 2024 21:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case error happens during status update request, reconcile will not be requeued. So, this call should be moved ouside
deferfunctionfixes #36