Skip to content

Add how to install operator locally; fix telegram link - #31

Merged
Kirill-Garbar merged 6 commits into
mainfrom
add-how-to-install
Mar 18, 2024
Merged

Kirill-Garbar merged 6 commits into
mainfrom
add-how-to-install

Conversation

@Kirill-Garbar

Copy link
Copy Markdown
Contributor

fixes #23
fixes #30

@Kirill-Garbar Kirill-Garbar self-assigned this Mar 16, 2024
@Kirill-Garbar
Kirill-Garbar marked this pull request as ready for review March 16, 2024 23:03
Comment thread HOW-TO-START-DEVELOPMENT.md Outdated
### Easy way
1. Download and install [kind](https://kind.sigs.k8s.io/docs/user/quick-start/#creating-a-cluster).
2. Create lind cluster `kind create cluster --name etcd-operator-kind`.
3. Switch kubectl context to kind `kubectl cluster-info --context kind-etcd-operator-kind`. Be attentive to avoid damaging your production environment.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would write it like kubectl set-context kind-etcd-operator-kind or something like that. The command you provided does not change context. Following make commands will be executed against some other cluster :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, will have a look today.
Probably I accidentally copied the wrong line from my history. At least I executed everything against correct cluster :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexGluck Alex Gluck (AlexGluck) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sircthulhu Kirill Ilin (sircthulhu) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kirill-Garbar
Kirill-Garbar merged commit 34d962d into main Mar 18, 2024
@Kirill-Garbar
Kirill-Garbar deleted the add-how-to-install branch March 18, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken telegram url in readme Write instructions how to run controller locally

3 participants