Write basic etcd-operator spec #9

Activity

1. Andrei Kvapil (kvaps)

   assigned

   Kirill Ilin (sircthulhu)

   on Mar 12, 2024
2. AlexGluck commented on Mar 12, 2024

   

   Alex Gluck (AlexGluck)

   on Mar 12, 2024

   Last edited by AlexGluck

   Contributor

   More actions

   1. Before we implement PodTemplate, i suggest add opt-in image in spec
   2. Solution for storage persistent: false use emptyDir, if not set default value true
   3. Solution for storage value storageClass opt-in, if not set use default storage class

   ---
   apiVersion: etcd.aenix.io/v1alpha1
   kind: EtcdCluster
   metadata:
     name: test
     namespace: ns1
   spec:
     replicas: 3
     image: ""
     persistent: false
     storage:
       size: 10Gi
   status:
     conditions:
     - lastProbeTime: null
        lastTransitionTime: "2024-03-06T18:39:39Z"
        status: "True"
        type: Initialized
     - lastProbeTime: null
        lastTransitionTime: "2024-03-06T18:39:45Z"
        status: "True"
        type: Ready
     - lastProbeTime: null
        lastTransitionTime: "2024-03-06T18:39:45Z"
        status: "True"
        type: Synchronized
   ...
   

   👍React with 👍2Reacted by Andrei Kvapil and Kirill Ilin
3. sedovandrew commented on Mar 13, 2024

   

   Andrew (sedovandrew)

   on Mar 13, 2024

   More actions

   1. I would suggest specifying the Etc version of the cluster in the spec. By default, the operator will use the latest version of Etc known to him, for example, v3.5.12 at the moment. Also specify the version in status, so that the operator understands which cluster he is servicing.
   2. I didn't see the field for the storage class.

   I suggest adding the following fields:

   spec:
     storage:
       class: storage-class-name  # optional #2
     version: v3.5.12  # optional #1
   status:
     version: v3.5.12  # #1

   Final manifest:

   apiVersion: etcd.aenix.io/v1alpha1
   kind: EtcdCluster
   metadata:
     name: test
     namespace: ns1
   spec:
     replicas: 3
     image: ""
     persistent: false
     storage:
       class: storage-class-name  # optional #2
       size: 10Gi
     version: v3.5.12  # optional #1
   status:
     conditions:
     - lastProbeTime: null
        lastTransitionTime: "2024-03-06T18:39:39Z"
        status: "True"
        type: Initialized
     - lastProbeTime: null
        lastTransitionTime: "2024-03-06T18:39:45Z"
        status: "True"
        type: Ready
     - lastProbeTime: null
        lastTransitionTime: "2024-03-06T18:39:45Z"
        status: "True"
        type: Synchronized
     version: v3.5.12  # #1

   It is also worth considering the list of Etcd versions supported by the operator.
4. sircthulhu commented on Mar 13, 2024

   

   Kirill Ilin (sircthulhu)

   on Mar 13, 2024

   Collaborator

   More actions

   Alex Gluck (@AlexGluck) thanks for your suggestions.
   I think I will include them in my implementation.

   Is there a reason for persistence field to be not in the .spec.storage but .spec?
5. Kirill Ilin (sircthulhu)

   added a commit that references this issue on Mar 13, 2024

   Generated EtcdCluster custom resource (#9)

   6c9fd31
6. George Gaál (gecube)

   added a commit that references this issue on Mar 13, 2024

   Basic EtcdCluster custom resource (#9) (#15)

   ...

   756f1a2
7. Andrei Kvapil (kvaps)

   added this to etcd-operatoron Mar 13, 2024
8. Andrei Kvapil (kvaps)

   moved this to In progress in etcd-operatoron Mar 13, 2024
9. Andrei Kvapil (kvaps)

   added this to the v0.0.1 milestone on Mar 13, 2024
10. Kirill Ilin (sircthulhu)

    closed this as completedon Mar 13, 2024
11. github-project-automation

    moved this from In progress to Done in etcd-operatoron Mar 13, 2024
12. kvaps commented on Mar 13, 2024

    

    Andrei Kvapil (kvaps)

    on Mar 13, 2024

    MemberAuthor

    More actions

    Fixed by #15 and #16
13. AlexGluck commented on Mar 14, 2024

    

    Alex Gluck (AlexGluck)

    on Mar 14, 2024

    Last edited by AlexGluck

    Contributor

    More actions

    Is there a reason for persistence field to be not in the .spec.storage but .spec?

    Nope
14. Kirill Ilin (sircthulhu)

    linked a pull request that will close this issueFix CR api group name #16on Mar 15, 2024
15. Kirill Ilin (sircthulhu)

    linked a pull request that will close this issueBasic EtcdCluster custom resource (#9) #15on Mar 15, 2024
16. Andrei Kvapil (kvaps)

    unassigned

    Kirill Ilin (sircthulhu)

    on Apr 3, 2024
17. Terry Tang (saymololy)

    added a commit that references this issue on Nov 2, 2026

    Merge pull request cozystack#9 from lllamnyp/chore/update-toolchain

    ...

    8e4ffa0