Repository navigation
Commit f3338e3
committed
docs(agent): correct the response-checksum rationale
The comment on the s3.Client options claimed ResponseChecksumValidation is
"the only server-side integrity signal the restore path has, since downloadS3
runs with SkipHashCheck". Both halves were wrong:
- SkipHashCheck is a field of etcdutl's snapshot.RestoreConfig (restore.go),
covering etcd's own appended snapshot hash. downloadS3 passes no such
option and has no equivalent.
- The signal it credits is inert for objects this agent writes: response
validation fires only when the backend returns an x-amz-checksum-* header,
and pinning requests to WhenRequired means no checksum is ever stored.
Leaving ResponseChecksumValidation at the SDK default is still right, so the
decision stands; only the reason changes. The same wrong text was duplicated
in the test comment and is corrected there too.
Also trim the rationale to one home on s3RequestChecksumCalculation with
pointers from the use sites, drop a commit hash that will not survive a
squash-merge, and use os.DevNull instead of a hardcoded /dev/null.
No behavior change: both mutation checks still fail closed (drop the client
option and the single-part test fails; drop the uploader option and the
multipart test fails).
Assisted-By: Claude Opus 4.8 (1M context)
Signed-off-by: Timofei Larkin <[email protected]>1 parent 562193d commit f3338e3
4 files changed
Lines changed: 29 additions & 37 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
171 | 169 | | |
172 | 170 | | |
173 | 171 | | |
| |||
196 | 194 | | |
197 | 195 | | |
198 | 196 | | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
215 | 203 | | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
216 | 212 | | |
217 | 213 | | |
218 | 214 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
46 | | - | |
47 | | - | |
| 47 | + | |
| 48 | + | |
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
| |||
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
86 | 85 | | |
87 | 86 | | |
88 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
255 | 252 | | |
256 | 253 | | |
257 | 254 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
220 | 220 | | |
221 | 221 | | |
222 | 222 | | |
223 | | - | |
224 | | - | |
| 223 | + | |
| 224 | + | |
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
| |||
0 commit comments