Skip to content

Allow lookup function in 'make diff'. - #647

Merged
Andrei Kvapil (kvaps) merged 1 commit into
cozystack:mainfrom
xy2:diff-lookups
Feb 25, 2025
Merged

Allow lookup function in 'make diff'.#647
Andrei Kvapil (kvaps) merged 1 commit into
cozystack:mainfrom
xy2:diff-lookups

Conversation

@xy2

@xy2 xy2 commented Feb 25, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Many applications require the lookup function on the live server. Allow its usage as well as in make show.

Summary by CodeRabbit

  • Chores
    • Updated the release diff operation to simulate the upgrade process on the server side, ensuring a safer preview without applying changes.

@dosubot dosubot Bot added the size/XS This PR changes 0-9 lines, ignoring generated files label Feb 25, 2025
@coderabbitai

coderabbitai Bot commented Feb 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The change updates the diff target in the Makefile by modifying the helm diff upgrade command to add the --dry-run=server flag. This adjustment ensures that the diff operation simulates the upgrade process on the server side without applying any changes. All other parameters (--show-secrets, --allow-unreleased, and --post-renderer) remain unchanged.

Changes

File Change Summary
scripts/package.mk Modified the helm diff upgrade command to include --dry-run=server, while retaining other flags.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Makefile
    participant HelmServer

    User->>Makefile: Execute diff target
    Makefile->>HelmServer: Run helm diff upgrade with --dry-run=server and other flags
    HelmServer->>Makefile: Return simulated upgrade result
    Makefile->>User: Display diff output
Loading

Poem

I'm a bouncy rabbit in the code burrow,
Hoping on changes that make features mellow,
Dry-run in action—no changes to fear,
Diff output shines, so bright and clear,
With a twirl of my ears and a joyful cheer!
Happy hops and code leaps near!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 24fa722 and e893b38.

📒 Files selected for processing (1)
  • scripts/package.mk (1 hunks)
🔇 Additional comments (1)
scripts/package.mk (1)

18-18: Good addition of server-side dry run to enable lookup function usage.

The addition of --dry-run=server to the helm diff command allows the lookup function to work during diff operations. This is consistent with the show target on line 10 which already uses this flag. This change will enable retrieving information from the live cluster during diff operations without applying any changes.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dosubot dosubot Bot added the kind/feature Categorizes issue or PR as related to a new feature label Feb 25, 2025
kvaps
Andrei Kvapil (kvaps) approved these changes Feb 25, 2025
View reviewed changes

@kvaps Andrei Kvapil (kvaps) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, this feature added in v3.9.0
https://github.com/databus23/helm-diff/releases/tag/v3.9.0

LGTM

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Feb 25, 2025
@kvaps
Andrei Kvapil (kvaps) merged commit 439381e into cozystack:main Feb 25, 2025
@xy2
xy2 deleted the diff-lookups branch February 28, 2025 19:55
@IvanHunters IvanHunters mentioned this pull request Oct 20, 2026
Merged
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvaps Andrei Kvapil (kvaps) kvaps approved these changes

Assignees

No one assigned

Labels

kind/feature Categorizes issue or PR as related to a new feature lgtm This PR has been approved by a maintainer size/XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xy2 @kvaps