test(release): pin the run attempt in TestReportDedupAndTrust by myasnikovdaniil · Pull Request #5283 · cozystack/cozystack

myasnikovdaniil · 2026-11-11T12:58:38Z

What this PR does

TestReportDedupAndTrust sets GITHUB_RUN_ID and expects run url https://github.com/cozystack/cozystack/actions/runs/100, but GITHUB_RUN_ATTEMPT comes from runner and runURL appends /attempts/N to every attempt after first. So test fails on any re-run and on fork PRs that waited for approval, their run starts as attempt 2 (example: https://github.com/cozystack/cozystack/actions/runs/43013119144/job/130507485285 on #5254, which doesn't touch cmd/). Test came with #5264.

Test now pins attempt to 1. Checked locally with GITHUB_RUN_ATTEMPT unset, 1, 2 and 3, and make test-backport-batch with GITHUB_RUN_ATTEMPT=2.

Downstream repositories

Release note

NONE

Summary by CodeRabbit

Tests
- Updated a test to include the GitHub run attempt environment variable.

The test sets the run ID it expects in the report's run URL but took the attempt from the runner, and runURL appends /attempts/N to any attempt past the first. A re-run, or a fork pull request whose run starts as attempt 2 once a maintainer approves it, failed the test whatever the change under review. Assisted-by: LLM Signed-off-by: Myasnikov Daniil <[email protected]>

coderabbitai · 2026-11-11T12:58:56Z

No actionable comments were generated in the recent review.

Walkthrough

TestReportDedupAndTrust now sets GITHUB_RUN_ATTEMPT to "1" alongside the other GitHub environment variables.

Changes: Backport report test setup

Layer / File(s)	Summary
Set run attempt in test setup `cmd/backport-batch/report_test.go`	`TestReportDedupAndTrust` sets `GITHUB_RUN_ATTEMPT` to `"1"`.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Possibly related PRs

cozystack/cozystack#5264: Adds the report feature and TestReportDedupAndTrust, which this change updates.
cozystack/cozystack#5269: Updates the report format and related tests; this change updates report-test environment setup.

Suggested labels: kind/bug, area/release

Merge Risk: Minimal · up to 2c84d

This change only makes a test deterministic across CI reruns. It does not affect production behavior and carries no identified merge risk.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: pinning the GitHub run attempt in TestReportDedupAndTrust.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.

Finishing Touches

Generate docstrings

Commit to this branch
Create a new PR

Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Source mode: Auto

Repository: cozystack/cozystack

Branch: main

File: .coderabbit.yaml

Commit: 3b4db69

Layers: Repository YAML

Review profile: CHILL

Plan: Advanced

Run ID: `341a679f-39fe-489e-a6da-d97385c71809`

Commits

Reviewing files that changed from the base of the PR and between `3b4db69` and `2c84d22`.

Files selected for processing: 1

`cmd/backport-batch/report_test.go`

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

myasnikovdaniil · 2026-11-12T08:40:16Z

Moved this fix into #5287, closing.

## What this PR does Full chainsaw run doesn't fit in 215 minutes anymore. Last four nightly runs were cancelled at the limit, and PRs that select full suite end same way while every suite that got to run passed (#5283 for example). This raises limit for all four jobs that run the suite (pull-requests, e2e-fork, e2e-tag, nightly) from 215 to 265, so they stay on one figure. Comments that state the cap follow it. Making e2e itself shorter is separate work. Part of #5261, `Collect report` ceiling in fork workflow from there is not covered here. ### Screenshots ### Downstream repositories - [x] No downstream repository is affected by this change - [ ] [cozystack/website](https://github.com/cozystack/website) - follow-up: - [ ] [cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack) - follow-up: - [ ] [cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack) - follow-up: - [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up: - [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up: - [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) - follow-up: - [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) - follow-up: - [ ] [cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server) - follow-up: - [ ] [cozystack/external-apps-example](https://github.com/cozystack/external-apps-example) - follow-up: - [ ] [cozystack/examples](https://github.com/cozystack/examples) - follow-up: - [ ] [cozystack/community](https://github.com/cozystack/community) - follow-up: ### Release note ```release-note ci(e2e): E2E job limit raised from 215 to 265 minutes. ```   ## Summary by CodeRabbit * **Chores** * Increased the time limit for end-to-end test runs from 215 to 265 minutes across applicable workflows. This allows longer test runs to complete before the overall job is stopped.

) ## What this PR does Stacked on #5288, merge that one first. PR touching only `cmd/backport-batch` was treated as code change, so it rebuilt every image, installed platform in e2e sandbox and ran full chainsaw suite plus whole unit lane. #5283 (one-line test fix) spent 3.5 hours in that e2e and hit job timeout. And backport-batch go tests were running on every code PR, whatever it touched. - plan job `code` output is now false when every changed path is under `docs/`, `cmd/backport-batch/` or `cmd/api-gate/` (CI-only tools, no image builds them). Builds, finalize and e2e are skipped and `E2E Tests` posted green, same as for docs-only PRs. `e2e-fork.yaml` skips on same prefixes, `hack/gate-concurrency-contract.bats` fails if two lists diverge. - `hack/build-matrix.sh` and `hack/select-e2e.sh` don't escalate to full rebuild or full suite because of these two dirs, so mixed PR is scoped by its other paths. Other `cmd/` dirs still escalate. - `test-backport-batch` removed from `make unit-tests`. Checks job runs it only when diff touches path from `cmd/backport-batch/test-inputs.txt` (tool itself, in-repo packages it imports, docs pages its tests read, `go.mod`, `go.sum`). `TestInputsListed` compares this list with `go list -deps -test` and fails when import is missing there. - new `docs` output keeps bats lane for docs changes and drops it for tool-only ones. - includes test fix from #5283 (pin run attempt in `TestReportDedupAndTrust`), this PR replaces it. ### Screenshots ### Downstream repositories - [x] No downstream repository is affected by this change - [ ] [cozystack/website](https://github.com/cozystack/website) - follow-up: - [ ] [cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack) - follow-up: - [ ] [cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack) - follow-up: - [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up: - [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up: - [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) - follow-up: - [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) - follow-up: - [ ] [cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server) - follow-up: - [ ] [cozystack/external-apps-example](https://github.com/cozystack/external-apps-example) - follow-up: - [ ] [cozystack/examples](https://github.com/cozystack/examples) - follow-up: - [ ] [cozystack/community](https://github.com/cozystack/community) - follow-up: ### Release note ```release-note ci: changes only in docs/, cmd/backport-batch/ or cmd/api-gate/ don't build images and don't run e2e anymore, backport-batch tests run only when their inputs change. ```   ## Summary by CodeRabbit * **Bug Fixes** * CI now skips builds, E2E tests, and full-pipeline checks for changes limited to documentation and designated CI-only tools. * Backport-batch tests run when relevant files change, without being included in the general unit-test target. * Changes to other command-line tools continue to trigger the appropriate build and E2E checks. * **Documentation** * Clarified how documentation, dashboard, and backport-batch changes affect test selection.

myasnikovdaniil requested review from IvanHunters, Andrei Kvapil (kvaps), Aleksei Sviridkin (lexfrei), Timofei Larkin (lllamnyp) and Kirill Ilin (sircthulhu) as code owners November 11, 2026 12:58

github-actions Bot added size/XS This PR changes 0-9 lines, ignoring generated files area/release Issues or PRs related to release tooling (changelog, backport, release pipeline) labels Nov 11, 2026

IvanHunters approved these changes Nov 11, 2026

View reviewed changes

myasnikovdaniil enabled auto-merge November 11, 2026 13:16

Aleksei Sviridkin (lexfrei) approved these changes Nov 11, 2026

View reviewed changes

coderabbitai Bot mentioned this pull request Nov 12, 2026

test(release): isolate report deduplication from workflow attempts #5282

Merged

1 of 12 tasks

myasnikovdaniil mentioned this pull request Nov 12, 2026

ci: run only the backport-batch tests for a backport-batch change #5287

Merged

1 of 12 tasks

myasnikovdaniil closed this Nov 12, 2026

auto-merge was automatically disabled November 12, 2026 08:40
Pull request was closed

myasnikovdaniil mentioned this pull request Nov 12, 2026

ci(e2e): raise the E2E job limit from 215 to 265 minutes #5288

Merged

1 of 12 tasks

Navigation Menu

Repository navigation

test(release): pin the run attempt in TestReportDedupAndTrust - #5283

test(release): pin the run attempt in TestReportDedupAndTrust#5283
myasnikovdaniil wants to merge 1 commit into
mainfrom
fix/backport-batch-run-attempt

myasnikovdaniil commented Nov 11, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Nov 11, 2026 •

edited

Loading

Uh oh!

myasnikovdaniil commented Nov 12, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

myasnikovdaniil commented Nov 11, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does

Downstream repositories

Release note

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Nov 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

myasnikovdaniil commented Nov 12, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

myasnikovdaniil commented Nov 11, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Nov 11, 2026 •

edited

Loading