Skip to content

[Backport release-1.7] feat(bucket): add a ui flag to skip the s3manager web UI - #5147

Open
mattia-eleuteri wants to merge 1 commit into
cozystack:release-1.7from
mattia-eleuteri:backport/4881-release-1.7
Open

mattia-eleuteri wants to merge 1 commit into
cozystack:release-1.7from
mattia-eleuteri:backport/4881-release-1.7

Conversation

@mattia-eleuteri

Copy link
Copy Markdown
Collaborator

What this PR does

Backport of #4881 to release-1.7, alongside #5146 for release-1.6.

The bucket-<name>-system release renders the users' credentials Secrets as well as the s3manager UI, and its install waits for the s3manager pod. When the tenant quota refuses that pod, the install times out and no user of the bucket gets credentials for 10 minutes or more. Operators who do not use the UI need the flag on 1.7 to take the pod out of that path.

0c62bee4d, the only commit of #4881, applies cleanly: release-1.7 already has cozy-lib.ns-host-required and the _cluster: {} default in the bucket-system values, so unlike #5146 neither a conflict resolution nor a test adaptation is needed.

make -C packages/apps/bucket generate leaves no diff, twice in a row. helm unittest packages/apps/bucket: 11 passed. helm unittest packages/system/bucket: 17 passed. helm template of packages/system/bucket renders the Service, Deployment and Ingress (or HTTPRoute behind a Gateway) with ui: true, none of them with ui: false, and with ui: false renders without a tenant apex; packages/apps/bucket passes ui through to the HelmRelease values in both cases.

Screenshots

Not a UI change: the flag removes the s3manager UI, it does not change it.

Downstream repositories

Walked the trigger map against the diff. As in #4881, a new field in packages/apps/bucket/values.schema.json reaches the Terraform provider and the hand-written Bucket page of the website; both follow-ups already exist as issues. The website issue targets content/en/docs/next/; whether the v1.6 docs get the same section is left to the docs maintainers.

Release note

feat(bucket): add a `ui` flag to the Bucket application. Set it to `false` to skip the s3manager web UI and its Service, Ingress or HTTPRoute, DNS name and TLS certificate. Defaults to `true`, so existing buckets are unchanged.

Every bucket ships an s3manager Deployment with its Service and an
Ingress or HTTPRoute on <bucket>.<tenant host>. Tenants that only use
the S3 API pay for a pod per bucket and for one DNS name and TLS
certificate per bucket, none of which they need.

ui defaults to true, so existing buckets keep their UI. With ui set to
false the bucket no longer needs the tenant apex either, since the UI
hostname was its only consumer in the bucket-system chart.

Assisted-by: LLM
Signed-off-by: Mattia Eleuteri <[email protected]>
(cherry picked from commit 0c62bee)
Signed-off-by: Mattia Eleuteri <[email protected]>
@mattia-eleuteri mattia-eleuteri added the kind/backport Categorizes issue or PR as requiring a backport to the current release line label Oct 28, 2026
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size/L This PR changes 100-499 lines, ignoring generated files area/release Issues or PRs related to release tooling (changelog, backport, release pipeline) area/storage Issues or PRs related to storage (linstor, seaweedfs, bucket, velero, harbor) kind/feature Categorizes issue or PR as related to a new feature labels Oct 28, 2026
@mattia-eleuteri
mattia-eleuteri marked this pull request as ready for review October 28, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/release Issues or PRs related to release tooling (changelog, backport, release pipeline) area/storage Issues or PRs related to storage (linstor, seaweedfs, bucket, velero, harbor) kind/backport Categorizes issue or PR as requiring a backport to the current release line kind/feature Categorizes issue or PR as related to a new feature size/L This PR changes 100-499 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant