Repository navigation
[Backport release-1.6] feat(bucket): add a ui flag to skip the s3manager web UI - #5146
Open
mattia-eleuteri wants to merge 2 commits into
Open
mattia-eleuteri wants to merge 2 commits into
mattia-eleuteri wants to merge 2 commits into
Conversation
Every bucket ships an s3manager Deployment with its Service and an Ingress or HTTPRoute on <bucket>.<tenant host>. Tenants that only use the S3 API pay for a pod per bucket and for one DNS name and TLS certificate per bucket, none of which they need. ui defaults to true, so existing buckets keep their UI. With ui set to false the bucket no longer needs the tenant apex either, since the UI hostname was its only consumer in the bucket-system chart. Assisted-by: LLM Signed-off-by: Mattia Eleuteri <[email protected]> (cherry picked from commit 0c62bee) Signed-off-by: Mattia Eleuteri <[email protected]>
On release-1.6 the bucket-system values carry no _cluster default, so the ingress template aborts the render with "index of untyped nil" unless the suite injects one, as the other suites of this chart do. Assisted-by: LLM Signed-off-by: Mattia Eleuteri <[email protected]>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
mattia-eleuteri
marked this pull request as ready for review
October 28, 2026 10:23
2 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Backport of #4881 to release-1.6.
The
bucket-<name>-systemrelease renders the users' credentials Secrets as well as the s3manager UI, and its install waits for the s3manager pod. When the tenant quota refuses that pod, the install times out and no user of the bucket gets credentials for 10 minutes or more. Operators who do not use the UI need the flag on 1.6 to take the pod out of that path.The cherry-pick of
0c62bee4d(the only commit of #4881) conflicted indeployment.yaml,ingress.yamlandhttproute.yamlofpackages/system/bucket: main reads the tenant apex throughcozy-lib.ns-host-required, which release-1.6 does not have. The resolution keeps the release-1.6.Values._namespace.hostlines and adds only theuiguard, so the templates differ from release-1.6 by exactly the{{- if .Values.ui }}/{{- end }}pair, as on main. On release-1.6 the apex was never required, so the "does not require the tenant apex" case passes trivially here.A second commit sets
_cluster: {}in the newpackages/system/bucketsuite: release-1.6 has no_clusterdefault in the chart values, and the ingress template aborts the render withindex of untyped nilwithout it, which the other suites of this chart already work around the same way.make -C packages/apps/bucket generateleaves no diff, twice in a row.helm unittest packages/apps/bucket: 11 passed.helm unittest packages/system/bucket: 10 passed.Screenshots
Not a UI change: the flag removes the s3manager UI, it does not change it.
Downstream repositories
Walked the trigger map against the diff. As in #4881, a new field in
packages/apps/bucket/values.schema.jsonreaches the Terraform provider and the hand-written Bucket page of the website; both follow-ups already exist as issues. The website issue targetscontent/en/docs/next/; whether the v1.6 docs get the same section is left to the docs maintainers.Release note