Repository navigation
[Backport release-1.7] fix(kubernetes, opensearch, foundationdb)!: restrict managed application images - #5108
Merged
Conversation
Author
|
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-5085-to-release-1.7
git worktree add --checkout .worktree/backport-5085-to-release-1.7 backport-5085-to-release-1.7
cd .worktree/backport-5085-to-release-1.7
git reset --hard HEAD^
git cherry-pick -x af20694359d4a2d085769389bf4106762e82eb77 941b50c675696ea74f31fa69e621cde23c747b58 873bd6712d44f425baa812610f7cdc33bc19c353 d62056ef0334dc79f38d519b912093ee660d93e7 46a9e125788754c3ad12823669417b61362d253d 930051280bf64e8cce58a1435829147a85c2992a f3058d23532d5ef37363a7ac00c881ec8fdb7d9f d99a1b9f2ffbca8a1a28a8111a18bd1f8f1060a6 a887125ee59b5e1503ccb7e69928321e930ca3e4 033bec74fb6494712aac2585b3b3f228256d140d a41015e3098844db5e89bd42aa4dc812c1ec7581 044162583b3d271998ea941c11c9d51743c5fe3d 8c2e20539d7d3b4e8296916b6ac480a20ae03f56 dfff5c2dac01904692959a3336a7605dab7af814 1636349a63f1605319b93e5f835c94dce84371ab d5ebb626329976febec3ba3395637d7361513610 448b12657bdbb8839f2248954a87b1f5711d89b7 9775628cc801c7a9cd07a44967d7901201d4f9c2 4cb505a5127dce8a67b957e4bac044860a1cc6ea b43196e549332b788029fb904be3b185fda0d669 465158f4a04b80a0870f7e286f623dedfbfbcecf 639ede20beb00fa04773aa7c94ece1c049943f5b 59932e50985bf57bbd51559ea43efa99f0d2a56d e694b05b4e43f4eaff2ea28f8bfa520ba995068f
git push --force-with-lease |
1 of 12 tasks
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
…ion images Image overrides let a tenant run an arbitrary container in the management cluster, including helpers with access to the Talos CA secrets and the tenant cluster's API credentials. Drop those overrides and run the images the platform ships. The Kubernetes and KubernetesNodes helpers (the wait-for-kubeconfig and Proxmox cloud-config init containers, the bootstrap-token and OIDC RBAC Jobs, the talos-csr-signer sidecar, the Talos reconcile and unpin Jobs) take the bundled image references through cozy-lib.image, so they still follow the configured registry. OpenSearch no longer sets an image and leaves it to the operator, which follows the version the chart's version map selects; an explicit version: null now fails the render instead of falling back to v2. The Talos installer settings for tenant worker VMs stay. FoundationDB replaces the free-form cluster.version with version, v7.3 or v7.4, mapped to 7.3.63 and 7.4.1; the 7.1 line is no longer offered. The chart refuses a render where cluster.version and version name different release lines, which also covers variants without platform migrations. Migration 60 carries an existing cluster.version over to its release line and leaves the legacy value in place while the old chart can still render it. It records what needs attention in the cozystack.io/migration-60-needs-attention annotation on the cozystack-version ConfigMap: a FoundationDB release it cannot carry over or whose patch changes, a release that still sets one of the removed image overrides, an OpenSearch release storing version: null. A dry run reports them without patching, annotating or advancing the stamp. Migration 56 stops carrying the removed kubectl override into adopted node pools. OpenSearch and FoundationDB get version-map update scripts that keep the current default while it is still supported. Stored image overrides are still accepted and the charts ignore them. On the first reconcile OpenSearch nodes move to the image of their selected version and Kubernetes components whose image changed restart. Air-gapped installations need docker.io and ghcr.io mirrored on the management-cluster nodes. Assisted-by: LLM (cherry picked from commit 749d401) Signed-off-by: Myasnikov Daniil <[email protected]>
myasnikovdaniil
force-pushed
the
backport-5085-to-release-1.7
branch
from
October 26, 2026 12:39
997fa7a to
a2d9cc7
Compare
myasnikovdaniil
marked this pull request as ready for review
October 26, 2026 12:46
myasnikovdaniil
requested review from
IvanHunters,
Andrey Kolkov (androndo),
Kingdon Barrett (kingdonb),
Andrei Kvapil (kvaps),
Aleksei Sviridkin (lexfrei),
Timofei Larkin (lllamnyp),
Matthieu ROBIN (matthieu-robin),
mattia-eleuteri,
myasnikovdaniil,
scooby87 and
Kirill Ilin (sircthulhu)
as code owners
October 26, 2026 12:46
Contributor
|
backport-audit: complete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5085 to
release-1.7.