Repository navigation
[Backport release-1.6] fix(virtual-machine): guard Kube-OVN IP lookup - #5061
Merged
Merged
Conversation
Helm's `lookup` propagates the discovery error when the requested API group is not served, so the vm-instance chart could not render at all on clusters without the Kube-OVN CRDs. Gate the IP lookup behind `.Capabilities.APIVersions.Has "kubeovn.io/v1/IP"`. The regression suite mocks the IP object through kubernetesProvider and pins both sides: with the API advertised the annotations carry the mocked MAC and IP, without it they are absent even though the object exists. helm-unittest's fake lookup never errors on an unserved kind, so only the second case distinguishes the guard; it fails on main and passes here. Assisted-By: GPT-5 <[email protected]> Signed-off-by: Loïc Fontaine <[email protected]> (cherry picked from commit b142d27)
1 of 11 tasks
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #4013 to
release-1.6.