chore(cilium): drop externalIPs.enabled and nodePort.enabled - #4953

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: cozystack/cozystack
• Branch: main
• File: .coderabbit.yaml
• Commit: 3ede7c4
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 28b4622a-a615-4407-9cd9-ba4550fec318

Commits

Reviewing files that changed from the base of the PR and between 700600e and f8217be.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

No actionable comments were generated in the recent review.

Merge Risk: Minimal · previous review 980de

This cleanup removes two unused Cilium values that could be mistaken for feature toggles. No runtime behavior change is expected, so merging carries minimal risk.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely states the main change: removing the unused Cilium external IP and NodePort settings.
Linked Issues check		Issue #4816 requires removal of cilium.externalIPs.enabled and cilium.nodePort.enabled from packages/system/cilium/values.yaml. The whole-PR diff removes both declarations and no other value dec…
Out of Scope Changes check		The diff contains only the four lines that define the two unused values in packages/system/cilium/values.yaml. The remaining loadBalancer configuration is unchanged. The change directly implements…
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.

Full details: Linked Issues check

Explanation

Issue #4816 requires removal of cilium.externalIPs.enabled and cilium.nodePort.enabled from packages/system/cilium/values.yaml. The whole-PR diff removes both declarations and no other value declarations. The PR reports unchanged rendered output for the default values and four listed variants, plus passing package tests. This supports the required no-runtime-change behavior.

Full details: Out of Scope Changes check

Explanation

The diff contains only the four lines that define the two unused values in packages/system/cilium/values.yaml. The remaining loadBalancer configuration is unchanged. The change directly implements issue #4816 and shows no unrelated change.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: cozystack/cozystack/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 22b29244-49af-4784-8c32-4b4a7ff83536

📥 Commits

Reviewing files that changed from the base of the PR and between aed7fa8 and 980de9d.

📒 Files selected for processing: 1

• packages/system/cilium/values.yaml

💤 Files with no reviewable changes: 1

• packages/system/cilium/values.yaml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Nimesh (@GitNimay) I merged main into your branch (990f37c) so CI runs against the current base. Your commits are unchanged.

Thanks for the review! I rewrote the commit. Its message now lists every nodePort key the chart still reads: range, addresses, bindProtection, autoProtectPortRange, directRoutingDevice, enableHealthCheck, enableHealthCheckLoadBalancerIP and enableDynamicSourceLookup. I also rebased it onto the current main, so the merge commit is gone, and added range to the PR description, which was missing it too. The diff is unchanged, and make test in packages/system/cilium still passes (26/26).