Repository navigation
[Backport release-1.6] ci(e2e): run nightly and release-tag e2e on the container lane - #4913
Merged
Merged
Conversation
The nightly e2e job runs on a 24-vCPU runner while its three management nodes take 8 vCPU each. On QEMU that is a 1:1 commit with nothing left for the host. On the container lane the job would not start at all: hack/e2e-container-up.sh refuses a host that does not have strictly more CPUs than the nodes take, and nightly checks out main's tree, which carries the same check. The next commit moves nightly onto the container lane, so move the job first to the 32-vCPU class the pull request and tag lanes on this branch already use. main made the same move in db2ddfa, together with a QEMU-specific headroom test that is not carried here. Assisted-by: LLM Signed-off-by: Myasnikov Daniil <[email protected]>
Nightly and the rc gate still booted the management nodes as QEMU guests, the substrate the merge-gating lanes left behind. On it the tenant Kubernetes suites have missed their node-join deadline on most nights since 2026-10-02, each failure spends the whole deadline, and the job reaches its timeout before the alphabetically later suites run. Over the same days those suites passed on every PR run that selected them, where the nodes are Talos containers and a tenant worker sits one virtualization level shallower. Both lanes now use the PR lanes' container substrate. Nightly's e2e no longer waits for the nocloud disk, which it does not boot; the disk is still built and published. A manual e2e-tag dispatch against a tag that predates the container lane fails early and names the ref to dispatch from instead. DRBD, the replicated StorageClass and the Cozystack Talos node image lose their last e2e coverage with this. The docs and comments that pointed at nightly and the rc gate as that coverage now say so. Assisted-by: LLM Signed-off-by: Aleksei Sviridkin <[email protected]> (cherry picked from commit da28ea7) Signed-off-by: Myasnikov Daniil <[email protected]>
github-actions
Bot
added
area/release
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
size/L
myasnikovdaniil
marked this pull request as ready for review
October 14, 2026 08:19
Contributor
Author
|
backport-audit: complete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Backport of #4828 to
release-1.6.PR lane on this line runs on Talos containers since the backport of #4020, but
e2e-tag.yaml(the rc gate thattags.yamlcalls for every rc fromrelease-1.6) andnightly.yamlstill boot QEMU guests. Every rc tag run here since v1.6.2-rc.1 is red. v1.6.4-rc.1 failed with kubernetes-latest and kubernetes-previous spending about 32 minutes each at node-join deadline (https://github.com/cozystack/cozystack/actions/runs/36124680874), while the same 41 suites passed on container lane in the v1.6.4 promotion PR, in a 93 minute job (https://github.com/cozystack/cozystack/actions/runs/36383277279).e2e plumbing on
release-1.6diverged frommainafter #4020, so the cherry-pick of the first commit has conflicts resolved against this branch, and there is one prerequisite commit:e2e-tag.yamlandnightly.yamlget the same host module step,prepare-env-container, endpoint and storage class env and two-part teardown aspull-requests.yamlhere.e2e-tag.yamlstill requires the release to carry its nocloud disk but doesn't download it anymore, and a dispatch against a tag cut before container lane (v1.6.3 and older) fails early and says to dispatch with--ref <tag>.hack/e2e-container-up.shrefuses a 24-vCPU host (maindid the same earlier in db2ddfa).Tests:
platform-packages_test.batschecks container lane env on all three lanes,promote-gate-contract.batscovers the new guard (onmainit lives incollect-images_test.bats, there is no such file here).Differences from
main: every lane keepstimeout-minutes: 180, the follow-up comment fix about 215-minute budget is not included (this branch has no such comment and no such value), fork lane wording is dropped because there is no fork split here, docs edits cover only paragraphs that exist on this branch.Coverage lost on this line: DRBD and the
replicatedStorageClass, Cozystack Talos node image with its extensions, CDI stock 600M worker memory limit. Docs and comments that pointed at the rc run as that coverage now say so.nightly.yamlruns only frommain, so the change there is for parity.tags.yamltakese2e-tag.yamlfrom the commit of the rc tag, so this has to merge before v1.6.5-rc.1 is cut. If rc is cut first, dispatchinge2e-tag.yamlfromrelease-1.6with that tag gives the same evidence.make bats-unit-testspasses locally (487 ok, base has 486), but the workflows themselves were not run yet. This stays a draft untile2e-tag.yamldispatched from this branch against v1.6.4-rc.1 is green, I will put the run link here.Downstream repositories
Release note