Repository navigation
feat(cozy-proxy): bump to v0.3.0 - #2510
Conversation
Pulls in the per-port filtering and allowICMP support that the companion vm-instance chart fix in #2501 relies on. cozy-proxy v0.3.0 also tightens the selector to the standard service.kubernetes.io/service-proxy-name=cozy-proxy label and switches the default ingress mode to port-filter; both are already covered by the vm-instance chart (label landed in #2357, wholeIP/allowICMP wired explicitly in #2501), so VM workloads upgrade transparently. Out-of-tree consumers using cozy-proxy annotations directly (without the label, or relying on the absent-annotation passthrough default) are called out in the upstream v0.3.0 release notes: https://github.com/cozystack/cozy-proxy/releases/tag/v0.3.0 Signed-off-by: Andrei Kvapil <[email protected]>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughVersion bump for the cozy-proxy Helm chart from 0.2.0 to 0.3.0, updating both chart metadata and container image tag to match. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bumps the vendored cozy-proxy chart and image tag from v0.2.0 to v0.3.0 by running
make updateinpackages/system/cozy-proxy.cozy-proxy v0.3.0 release: https://github.com/cozystack/cozy-proxy/releases/tag/v0.3.0
Why
cozy-proxy v0.3.0 is the companion of #2501. The chart fix in #2501 finally honors the documented PortList semantics (only
externalPortsreachable, ICMP preserved by default), but only takes effect once cozy-proxy v0.3.0 is in place — v0.2.0 has no port-aware logic, so the chart fix silently no-ops on it. This PR ships that runtime side.Upgrade impact
For cozystack users this is a bug fix, not a breaking change. cozy-proxy v0.3.0 introduces two contract changes upstream — (1) label-only selector via
service.kubernetes.io/service-proxy-name: cozy-proxy, and (2) port-filter as the default ingress mode — both of which are absorbed by the vm-instance chart (label landed in #2357,wholeIP+allowICMPwired in #2501).externalMethod: WholeIP(default) — chart renders label +wholeIP: "true"in both old and new versions. cozy-proxy keeps passthrough. No change.externalMethod: PortList— previously the chart always renderedwholeIP: "true"regardless of method, and cozy-proxy v0.2.0 had no port-aware logic, so PortList was silently a no-op (all ports reachable). After this bump + [vm-instance] Fix PortList not filtering ingress ports #2501, PortList behaves as documented: only ports listed inexternalPortsreach the VM. Users who configured PortList but reached undeclared ports (relying on the silent no-op) will see those ports become unreachable — that's the documented intent of PortList finally taking effect. ICMP keeps working by default thanks toexternalAllowICMP: true.Out-of-tree consumers using cozy-proxy directly (without the
service-proxy-namelabel, or relying on the absent-annotation passthrough default) need to migrate per the upstream v0.3.0 release notes — not a cozystack concern.Order of operations
This PR is functionally complete on its own (image bump), but the user-facing PortList fix it enables only happens when #2501 also lands. Recommended merge order:
The reverse order is also safe — cozy-proxy v0.3.0 with the unmodified vm-instance chart still produces correct results for
externalMethod: WholeIP(most common case) and keeps PortList silently broken until #2501 lands.Test plan
helm template packages/system/cozy-proxy— image tagv0.3.0renderedmake unit-testspassesexternalMethod: PortListwithexternalPorts: [22]filters all other ports, ping worksCompanion PRs
wholeIP/allowICMPperexternalMethodSummary by CodeRabbit