Post upgrade fixes for v1.0 packagesources by nbykov0 · Pull Request #1930 · cozystack/cozystack

Nikita (nbykov0) · 2026-01-28T17:11:23Z

What this PR does

Fixes v1.0 packagesources.

Release note

V1.0 packagesources fixed after an upgrade was performed.

Summary by CodeRabbit

Chores
- Updated platform component configurations for cozy-proxy and metrics-server deployments.
- Reorganized monitoring component namespace allocation.
- Added metrics server as a dependency in the monitoring pipeline.
- Integrated new system components (linstor-scheduler and metrics-server) into the platform templates.
- Refined HelmRelease chart references for vertical pod autoscaler.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Signed-off-by: nbykov0 <[email protected]>

coderabbitai · 2026-01-28T17:11:32Z

📝 Walkthrough

Walkthrough

This PR updates Helm release configurations, deployment namespaces, component dependencies, and template inclusions across platform packages. Changes include releaseName and namespace modifications, a new metrics-server dependency addition, and new package template includes for the system bundle.

Changes

Cohort / File(s)	Summary
Helm release configuration updates `packages/core/platform/sources/cozy-proxy.yaml`, `packages/core/platform/sources/metrics-server.yaml`, `packages/system/vertical-pod-autoscaler/templates/vpa-for-vpa.yaml`	Updated releaseName from "cozystack" to "cozy-proxy"; changed install.namespace from "cozy-metrics-server" to "cozy-monitoring"; modified HelmRelease chart reference name for VPA configuration
Dependency and template modifications `packages/core/platform/sources/monitoring-agents.yaml`, `packages/core/platform/templates/bundles/system.yaml`	Added cozystack.metrics-server dependency to monitoring-agents; added linstor-scheduler and metrics-server package inclusions to system bundle template

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop and a skip through config so fine,
Namespaces dance, dependencies align,
Charts are renamed with a careful touch,
Bundles bloom bright—we've changed quite much!
✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Post upgrade fixes for v1.0 packagesources' directly aligns with the PR's primary objective of fixing packagesources following a v1.0 upgrade, and accurately describes the main changes across multiple configuration files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist · 2026-01-28T17:11:44Z

Summary of Changes

Hello Nikita (@nbykov0), I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements several critical fixes for v1.0 package sources following a recent platform upgrade. The changes primarily involve adjusting component configurations, updating namespace assignments, and ensuring correct dependencies and inclusions within the system bundles. These modifications are essential for the stable operation of the platform's services post-upgrade.

Highlights

Configuration Updates: Corrected release names and namespaces for cozy-proxy and metrics-server components to align with post-upgrade requirements.
Dependency Management: Established a new dependency for monitoring-agents on metrics-server, ensuring proper ordering and availability of services.
System Bundle Enhancements: Integrated linstor-scheduler and metrics-server into the core system bundle, making them part of the default platform deployment.
VPA Chart Reference Fix: Updated the chartRef.name for the Vertical Pod Autoscaler (VPA) component to reflect a standardized naming convention.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	Gemini (@gemini-code-assist)	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a series of fixes for v1.0 packagesources, likely following a system upgrade. The changes involve correcting release names and namespaces in package source definitions, adding a missing dependency for monitoring agents, and including necessary packages like linstor-scheduler and metrics-server into the system bundle. Overall, the changes are logical and appear to be necessary corrections. I have one suggestion to improve the maintainability of a template file by reordering package inclusions to better reflect their dependency hierarchy.

gemini-code-assist · 2026-01-28T17:13:17Z

 {{include "cozystack.platform.package.default" (list "cozystack.vertical-pod-autoscaler" $) }}
+{{include "cozystack.platform.package.default" (list "cozystack.metrics-server" $) }}
 {{include "cozystack.platform.package.default" (list "cozystack.monitoring-agents" $) }}
 {{include "cozystack.platform.package.default" (list "cozystack.goldpinger" $) }}
 {{include "cozystack.platform.package.default" (list "cozystack.prometheus-operator-crds" $) }}


For better readability and maintainability, it's good practice to order package inclusions based on their dependencies. While the deployment order is handled by dependsOn, aligning the order in this file improves clarity for future maintenance.

The dependencies are as follows:

monitoring-agents depends on metrics-server.

metrics-server depends on prometheus-operator-crds.

I suggest reordering these lines to reflect this dependency chain.

{{include "cozystack.platform.package.default" (list "cozystack.vertical-pod-autoscaler" $) }} {{include "cozystack.platform.package.default" (list "cozystack.prometheus-operator-crds" $) }} {{include "cozystack.platform.package.default" (list "cozystack.metrics-server" $) }} {{include "cozystack.platform.package.default" (list "cozystack.monitoring-agents" $) }} {{include "cozystack.platform.package.default" (list "cozystack.goldpinger" $) }}

coderabbitai

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In `@packages/core/platform/sources/cozy-proxy.yaml`:
- Around line 19-21: The Helm releaseRename from "cozystack" to "cozy-proxy"
will leave the old release behind and can create duplicate/orphaned
cluster-scoped resources; update the upgrade path to explicitly uninstall or
migrate the old release before installing the new one by adding a
pre-upgrade/uninstall step in your deployment/upgrade script or a Helm
pre-upgrade hook that runs helm uninstall --namespace cozy-system cozystack (or
runs a migration job), and document this manual step in the chart/README so
operators know to remove or reconcile the old "cozystack" release prior to
applying the new releaseName "cozy-proxy".

In `@packages/core/platform/sources/metrics-server.yaml`:
- Around line 20-21: The namespace change of the metrics-server Helm release
from "cozy-metrics-server" to "cozy-monitoring" will create a new release and
leave cluster-scoped resources owned by the old release; add an explicit
migration/upgrade step that detects the prior release in "cozy-metrics-server"
and either uninstalls it or transfers ownership before applying the new manifest
in "cozy-monitoring": implement a pre-install hook or CI job that (1) checks for
the previous release name/namespace "cozy-metrics-server", (2) deletes or
migrates cluster-scoped resources (ClusterRole, ClusterRoleBinding, APIService)
or uses helm --replace/ --cleanup-on-fail patterns to avoid orphaned resources,
and (3) only proceeds to apply the new install namespace "cozy-monitoring" when
the prior release and its cluster-scoped resources are removed or ownership
reconciled.

## What this PR does Fixes v1.0 packagesources. ### Release note ```release-note V1.0 packagesources fixed after an upgrade was performed. ```  ## Summary by CodeRabbit * **Chores** * Updated platform component configurations for cozy-proxy and metrics-server deployments. * Reorganized monitoring component namespace allocation. * Added metrics server as a dependency in the monitoring pipeline. * Integrated new system components (linstor-scheduler and metrics-server) into the platform templates. * Refined HelmRelease chart references for vertical pod autoscaler. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>

Post upgrade fixes for v1.0 packagesources

1741651

Signed-off-by: nbykov0 <[email protected]>

gemini-code-assist Bot reviewed Jan 28, 2026

View reviewed changes

Nikita (nbykov0) self-assigned this Jan 28, 2026

Nikita (nbykov0) marked this pull request as ready for review January 28, 2026 17:13

Nikita (nbykov0) requested review from Andrei Kvapil (kvaps) and Timofei Larkin (lllamnyp) as code owners January 28, 2026 17:13

dosubot Bot added size/XS This PR changes 0-9 lines, ignoring generated files kind/bug Categorizes issue or PR as related to a bug labels Jan 28, 2026

coderabbitai Bot reviewed Jan 28, 2026

View reviewed changes

Comment thread packages/core/platform/sources/cozy-proxy.yaml Resolved

Comment thread packages/core/platform/sources/metrics-server.yaml Resolved

Andrei Kvapil (kvaps) approved these changes Jan 29, 2026

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label Jan 29, 2026

Andrei Kvapil (kvaps) merged commit 326921f into main Jan 29, 2026
10 checks passed

Andrei Kvapil (kvaps) deleted the upd-packagesources branch January 29, 2026 09:16

dosubot Bot mentioned this pull request Feb 23, 2026

monitor-agents failed to install after upgraded to v1.0.0-rc.1 #2084

Closed

5 tasks done

Navigation Menu

Repository navigation

Post upgrade fixes for v1.0 packagesources - #1930

Post upgrade fixes for v1.0 packagesources#1930
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
upd-packagesources

Nikita (nbykov0) commented Jan 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jan 28, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

gemini-code-assist Bot commented Jan 28, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Jan 28, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Nikita (nbykov0) commented Jan 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does

Release note

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

gemini-code-assist Bot commented Jan 28, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Nikita (nbykov0) commented Jan 28, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jan 28, 2026 •

edited

Loading