Skip to content

Create LoadBalancer service for single-node MySQL - #1113

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
1095-mysql-lb
Jun 28, 2025
Merged

Create LoadBalancer service for single-node MySQL#1113
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
1095-mysql-lb

Conversation

@lllamnyp

@lllamnyp Timofei Larkin (lllamnyp) commented Jun 25, 2025 •
edited by NickVolynkin
Loading

Copy link
Copy Markdown
Member

Changelog

[mysql] Bugfix: external=true did not work for MySQL deployed with a single replica,
since the MariaDB operator does not create separate primary and secondary services for a single-node DB.
A special condition is added to make the "all-node" service a LoadBalancer if external=true and replicas=1.

Summary by CodeRabbit

  • New Features
    • Improved handling of external service exposure for MySQL deployments, with refined logic for LoadBalancer configuration based on the number of replicas.
  • Chores
    • Updated MySQL chart version to 0.8.2.
    • Adjusted version mapping to reflect the latest changes.

Resolves #1095

@lllamnyp
Create LoadBalancer service for single-node MySQL
848abc4 
[mysql] Bugfix: external=true did not work for MySQL deployed with a
single replica, since the MariaDB operator does not create separate
primary and secondary services for a single-node DB. A special condition
is added to make the "all-node" service a LoadBalancer if external=true
and replicas=1.

Signed-off-by: Timofei Larkin <[email protected]>
@coderabbitai

coderabbitai Bot commented Jun 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The changes update the MySQL application's Helm chart version to 0.8.2, refine the conditional logic for Kubernetes service types in the MariaDB template based on external access and replica count, and update the version mapping to include the new version and its commit references.

Changes

File(s) Change Summary
packages/apps/mysql/Chart.yaml Incremented chart version from 0.8.1 to 0.8.2.
packages/apps/mysql/templates/mariadb.yaml Refined conditional logic for service type: now differentiates behavior based on external flag and replica count.
packages/apps/versions_map Updated version mapping: 0.8.1 now points to a commit hash, 0.8.2 added pointing to HEAD.

Suggested labels

enhancement, size:S, lgtm

Poem

A hop, a skip, a version jump anew,
With smarter logic, services accrue.
Now LoadBalancers know when to appear,
Depending on replicas far or near.
The chart is bumped, the map aligned—
Another release, precisely defined!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4369b03 and 848abc4.

📒 Files selected for processing (3)
  • packages/apps/mysql/Chart.yaml (1 hunks)
  • packages/apps/mysql/templates/mariadb.yaml (2 hunks)
  • packages/apps/versions_map (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build
🔇 Additional comments (3)
packages/apps/mysql/templates/mariadb.yaml (1)

75-78: Primary-service LoadBalancer condition looks correct

The conditional ensures the LoadBalancer is only created for the primary service when running > 1 replicas, preventing unnecessary external exposure of the all-nodes service. 👍

packages/apps/mysql/Chart.yaml (1)

19-19: Chart version bump acknowledged

Version increased to 0.8.2, consistent with the new template logic. No further action required.

packages/apps/versions_map (1)

66-67: Version map updated correctly

0.8.1 is now pinned and 0.8.2 points to HEAD, keeping the history reproducible. Looks good.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

kvaps
Andrei Kvapil (kvaps) approved these changes Jun 26, 2025
View reviewed changes

@kvaps Andrei Kvapil (kvaps) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickVolynkin Nick Volynkin (NickVolynkin) mentioned this pull request Jun 26, 2025
Closed
kvaps
Andrei Kvapil (kvaps) approved these changes Jun 28, 2025
View reviewed changes

@kvaps Andrei Kvapil (kvaps) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvaps
Andrei Kvapil (kvaps) merged commit 6732205 into main Jun 28, 2025
@kvaps
Andrei Kvapil (kvaps) deleted the 1095-mysql-lb branch June 28, 2025 11:36
@coderabbitai coderabbitai Bot mentioned this pull request Jul 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvaps Andrei Kvapil (kvaps) kvaps approved these changes
@klinch0 klinch0 Awaiting requested review from klinch0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Single-node MySQL does not create a LoadBalancer service

2 participants

@lllamnyp @kvaps