Skip to content

docs(release): changelog check B looks for images/*/Dockerfile, which does not exist #4892

Open

Description

Check B of the changelog verification in docs/release.md never finds a changed image. It lists changed image build files with:

git diff --name-only $PREV..$NEW -- 'images/*/Dockerfile'

There is no images/ directory at the repository root. Image build files live under packages/*/*/images/, so the command prints nothing on every release and the check passes without looking at anything. For example, cfa9c5a changes packages/core/testing/images/e2e-sandbox/Dockerfile, and the pathspec above returns no files for it, while '*Dockerfile' returns that file.

The line also skips Containerfile, which new first-party images use.

A pathspec like '*Dockerfile' '*Containerfile' covers both. I have not checked how much noise vendored chart images add to it.

Activity

  1. added
    kind/bugCategorizes issue or PR as related to a bug
    kind/documentationCategorizes issue or PR as related to documentation
    area/releaseIssues or PRs related to release tooling (changelog, backport, release pipeline)
    on Oct 13, 2026
  2. harshitrwt commented on Oct 17, 2026

    @harshitrwt
    Contributor

    Hi Aleksei Sviridkin (@lexfrei) , Can i work on this? The Images/Dockerfile matches nothing (all 51 Dockerfile/Containerfile paths are under packages/images/). I’ll switch the pathspec to 'Dockerfile' 'Containerfile'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/releaseIssues or PRs related to release tooling (changelog, backport, release pipeline)kind/bugCategorizes issue or PR as related to a bugkind/documentationCategorizes issue or PR as related to documentationtriage/needs-triageIndicates an issue needs triage by a maintainer

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions