You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(cilium): drop externalIPs.enabled and nodePort.enabled, the Cilium chart does not read them #4816
packages/system/cilium/values.yaml sets two Cilium switches that do nothing: cilium.externalIPs.enabled: true and cilium.nodePort.enabled: true. The vendored chart in packages/system/cilium/charts/cilium reads neither of them, on main (1.19.5) and on the 1.20.2 bump in #3343.
The configmap template only reads nodePort.range, nodePort.addresses, nodePort.directRoutingDevice and nodePort.enableHealthCheck. There is no externalIPs key in the upstream values.yaml at all.
Nothing changes at runtime. The problem is a reader who sees these keys and assumes they turn the features on or off. I'd delete both.
Hi! I'd like to take this one. I checked the vendored chart at 1.20.2 and confirmed externalIPs.enabled and nodePort.enabled aren't read anywhere in charts/cilium/templates, so I'll remove both keys from packages/system/cilium/values.yaml and open a PR shortly.
Activity
GitNimay commentedon Oct 19, 2026
Hi! I'd like to take this one. I checked the vendored chart at 1.20.2 and confirmed
externalIPs.enabledandnodePort.enabledaren't read anywhere incharts/cilium/templates, so I'll remove both keys frompackages/system/cilium/values.yamland open a PR shortly.chore(cilium): drop externalIPs.enabled and nodePort.enabled