Skip to content

e2e: the HelmRelease history guard does not read the KubernetesNodes pool release #4737

Closed

Description

The node pool release kubernetes-nodes-<test>-md0 is an Application HelmRelease, so the aggregated apiserver stamps RetryOnFailure on it (pkg/registry/apps/application/rest.go) the same way it stamps the parent. It sits directly on the node-join path, through the talos-reconcile Job. The status.history guard in hack/e2e-chainsaw/_lib/run-kubernetes.sh (cozy_guard_all_helmreleases) selects addon releases by the kubernetes-<test>- prefix. That prefix does not match this name, so a failed action on the pool release is never read, on the passing path or on the failure-path report. This gap predates the guard rework, since only the parent was read before it.

The fix is probably one more cozy_guard_helmrelease tenant-test kubernetes-nodes-<test>-md0 required call in cozy_guard_all_helmreleases, plus the same release in cozy_report_helmrelease_remediation, once someone confirms the release name is stable across the suites. The related csi-proxmox strategy pin is tracked in #4731.

Activity

  1. themoriarti commented on Oct 19, 2026

    @themoriarti
    Collaborator

    Fix in #4970: cozy_guard_all_helmreleases now reads kubernetes-nodes-<test>-md0, derived from the parent name, with the same required strategy check as the parent, and the failure-path report reads it too after checking that it exists. Unit tests cover both paths.

  2. added
    triage/acceptedIndicates an issue is ready to be actively worked on
    and removed
    triage/needs-triageIndicates an issue needs triage by a maintainer
    on Oct 19, 2026
  3. added 2 commits that reference this issue on Oct 29, 2026
    cac1520
    013b166
  4. added 2 commits that reference this issue on Nov 10, 2026
    7b57097
    53a1d2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bugtriage/acceptedIndicates an issue is ready to be actively worked on

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions