Repository navigation
e2e: the leak-guard allowlist and the suite docs assume every suite is a chainsaw-test.yaml #4659
Description
The e2e selectors now see every layout Chainsaw runs (#4630): chainsaw-test.yaml, chainsaw-test.yml, numbered step files, and a Test nested below a suite directory. Three places still assume the first layout only.
hack/e2e-chainsaw/_lib/leak-guard.sh,lg_allowlist_validate, accepts only<suite>/chainsaw-test.y*mlentries, so a step-file or nested suite cannot be put on the allowlist and fails validation loudly.hack/e2e-chainsaw/README.mdsays each suite has achainsaw-test.yaml.docs/agents/e2e-testing.mdcalls the Proxmox suite the one disabled suite, buthack/e2e-chainsaw/backup/also holds only achainsaw-test.yaml.disabled.
Fix shape: validate allowlist entries against the same discovery rule the selectors use, and describe the layouts once in the README with the doc pointing at it. Drop the "one suite" count rather than fixing it.
Reacted by dosubot
Activity
lexfrei commentedon Oct 1, 2026
Two more selector edges of the same kind, found while finishing #4658, both unchanged from main:
examples/backups/whose name matches no suite (for exampleexamples/backups/common/helpers.sh) selects nothing. ci: the e2e selectors miss Chainsaw step-file suites and loose files under examples/backups #4630 covered only files placed directly inexamples/backups/, plus_lib/.hack/e2e-chainsaw-run.shrefuses a top-level test with the globschainsaw-test.y*mland[0-9]*-*.y*ml, which are wider than Chainsaw's own step-file pattern. It fails closed (stops the run), so this is a precision issue, not a coverage hole.lexfrei commentedon Oct 1, 2026
One more instance of the same drift:
hack/e2e-chainsaw/README.mdhas no entries for thebackup,kafka-metadataandkubernetes-proxmoxsuites (#4678 addsmonitoring).themoriarti commentedon Oct 19, 2026
Fix in #4972 for the allowlist validation (same discovery rule as
select-e2e.sh, with unit tests for every layout) and the docs. Two items are left as they are, with the reasons in the PR: thebackupdirectory is gone from main, so the "one parked suite" sentence is correct now, and the runner's top-level globs are wider than Chainsaw's pattern but fail closed.fix(e2e): validate the leak allowlist against every suite layout
fix(e2e): validate the leak allowlist against every suite layout (coz…
fix(e2e): validate the leak allowlist against every suite layout
fix(e2e): validate the leak allowlist against every suite layout (#4972)