Repository navigation
Description
The comments around the helm install and upgrade timeout overrides call them per-Application, but the value is set once per kind. cozystack-api reads release.cozystack.io/helm-install-timeout and release.cozystack.io/helm-upgrade-timeout from the kind's ApplicationDefinition (pkg/cmd/server/start.go:305-316) and uses the same value for every Application of that kind. The annotations of an Application itself are not read for this, so someone who takes "per-Application" literally sets the annotation on one Application and nothing changes.
Places on origin/main at a759190:
pkg/registry/apps/application/rest.go:1612, "Per-Application annotation overrides win over the global defaults"pkg/config/config.go:207and:213, the field docs ofHelmInstallTimeoutandHelmUpgradeTimeoutpkg/config/config.go:232and:236, the field docs ofHelmReleaseInstallTimeoutandHelmReleaseUpgradeTimeoutpkg/cmd/server/start.go:278-280
There is a second gap in two of them. config.go:236 says HelmReleaseUpgradeTimeout is overridden by HelmInstallTimeout and does not mention HelmUpgradeTimeout, which overrides it too and wins over both (rest.go:1633-1635). start.go:280 names only the install annotation in the same way.
The fix is wording only. Say "per kind" or "from the ApplicationDefinition" where these comments say "per-Application", and name both annotations where only one is named.
Activity
docs(api): clarify kind-wide Helm timeout overrides
docs(api): clarify kind-wide Helm timeout overrides
docs(api): clarify kind-wide Helm timeout overrides (#4493)