Skip to content

test: nothing verifies the seam between the seaweedfs app chart and the data-plane chart #4285

Closed

Description

Describe the bug

Nothing tests the seam between the two SeaweedFS charts. One suite checks the values the app chart writes into its HelmRelease, the other checks what the data-plane chart renders from its own defaults, and no test feeds the first one's output into the second. A reviewer has been doing that step by hand to answer "does this value actually reach the master".

Environment

  • Cozystack: main

To Reproduce

Read packages/extra/seaweedfs/tests/ and packages/system/seaweedfs/tests/. The first asserts on spec.values inside the rendered HelmRelease; the second asserts on the container command rendered from the data-plane chart's own values. Neither takes the former as input to the latter.

Expected behaviour

A change in either chart that breaks the hand-off is caught by a test rather than by whoever thinks to render both.

Actual behaviour

Both suites pass while the merge between them is unverified. The shape a regression would take: the app chart writes a key the data-plane chart no longer reads, or a chart bump moves a key, and each side stays internally consistent.

Additional context

This came up because the merge does matter here and was checked manually during review: rendering the app chart, extracting spec.values from the HelmRelease, and feeding that into the data-plane chart produced -volumeSizeLimitMB=500 and COPY_2=3 with COPY_1=7 and COPY_3=3 intact. That is the check nothing automates, and doing it by hand is how the gap stayed invisible.

Worth deciding how far it generalises before building anything. The same two-chart shape exists elsewhere in the tree, so a helper that renders a chart, lifts spec.values out of a HelmRelease and renders the target with them would serve more than this pair. A one-off test for SeaweedFS would close this instance and leave the shape uncovered.

Checklist

  • I have checked the documentation
  • I have searched for similar issues
  • I have included all required information
  • I have provided clear steps to reproduce
  • I have included relevant logs

Activity

  1. added
    kind/bugCategorizes issue or PR as related to a bug
    area/testingIssues or PRs related to testing (e2e, bats, unit tests)
    area/storageIssues or PRs related to storage (linstor, seaweedfs, bucket, velero, harbor)
    on Sep 15, 2026
  2. added
    triage/acceptedIndicates an issue is ready to be actively worked on
    priority/backlogGeneral backlog priority. Lower than priority/important-longterm
    and removed
    triage/needs-triageIndicates an issue needs triage by a maintainer
    on Sep 23, 2026
  3. added a commit that references this issue on Oct 3, 2026
    9c9a8c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area/storageIssues or PRs related to storage (linstor, seaweedfs, bucket, velero, harbor)area/testingIssues or PRs related to testing (e2e, bats, unit tests)kind/bugCategorizes issue or PR as related to a bugpriority/backlogGeneral backlog priority. Lower than priority/important-longtermtriage/acceptedIndicates an issue is ready to be actively worked on

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions