bug(api): apps.cozystack.io apiserver ignores --dry-run=server and persists the write #3971

Activity

1. scooby87

   added

   kind/bugCategorizes issue or PR as related to a bugCategorizes issue or PR as related to a bug

   area/apiIssues or PRs related to the cozystack-api aggregated API serverIssues or PRs related to the cozystack-api aggregated API server

   on Aug 26, 2026
2. dosubot commented on Aug 26, 2026

   

   dosubotBot

   on Aug 26, 2026 – with DosuBot

   More actions

   scooby87 This is a duplicate of #2981, which has the same root-cause analysis and suggested fix.

   Root cause: REST.Update() in rest.go receives options *metav1.UpdateOptions but discards it. At line 609 it constructs a brand-new empty UpdateOptions:

   updateErr := r.c.Update(ctx, helmRelease, &client.UpdateOptions{Raw: &metav1.UpdateOptions{}})

   This drops DryRun, FieldManager, and FieldValidation. The sibling Create and Delete paths forward the incoming options correctly — Create at line 245 passes &client.CreateOptions{Raw: options}, and Delete at line 691 passes &client.DeleteOptions{Raw: options} [1].

   Fix — two spots, mirroring Create/Delete:

   1. Main update path (line 609):

      // before
      updateErr := r.c.Update(ctx, helmRelease, &client.UpdateOptions{Raw: &metav1.UpdateOptions{}})
      // after
      updateErr := r.c.Update(ctx, helmRelease, &client.UpdateOptions{Raw: options})

   2. Create-on-update (upsert) path (line 502):

      // before
      createdObj, err := r.Create(ctx, obj, createValidation, &metav1.CreateOptions{})
      // after
      createdObj, err := r.Create(ctx, obj, createValidation, &metav1.CreateOptions{DryRun: options.DryRun})

   This affects every apps.cozystack.io kind (Postgres, MariaDB, Kafka, VMDisk, Kubernetes, etc.), not just VMDisk [1].

   To reply, just mention @dosu.

   ---

   Share context across your team and agents. Try Dosu.

   
3. github-actions

   added

   triage/needs-triageIndicates an issue needs triage by a maintainerIndicates an issue needs triage by a maintainer

   on Aug 26, 2026
4. scooby87

   closed this as completedon Aug 27, 2026
5. scooby87

   added a commit that references this issue on Sep 2, 2026

   fix(vm-disk): fail on storageClass/source edit of existing disk (#3969)

   ...

   3a70f91