You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Console: VMDisk detail page fires CDIConfig and SSAR queries on every disk, not only upload disks #3957
DiskUploadPanel issues a CDIConfig GET and a SelfSubjectAccessReview POST before it knows whether the disk is an upload-source disk. Both hooks sit above the if (!isUploadSource(dv)) return null guard, so every VMDisk detail page pays for them, including disks that will never show the panel. The SSAR also goes out with namespace: "" when the namespace is not yet resolved.
Two halves, and they need different fixes.
The CDIConfig query can be gated on the DV load, but doing it naively makes things worse: CDIConfig then resolves after the DataVolume, so the panel renders once with the placeholder and flashes the "This cluster publishes no upload proxy URL" warning before the real value arrives. Any fix here has to hold the warning until CDIConfig has settled.
The SSAR half cannot be gated at all today. useSelfSubjectAccessReview takes only a spec and no options object, so there is no enabled to pass. That needs an enabled option added to the hook in @cozystack/k8s-client, which is why it was left out of #3847 rather than folded into an approved PR.
Raised by IvanHunters in review, deferred deliberately.
Activity