Skip to content

Console: VMDisk detail page fires CDIConfig and SSAR queries on every disk, not only upload disks #3957

Open

Description

@myasnikovdaniil

Follow-up from review on #3847.

DiskUploadPanel issues a CDIConfig GET and a SelfSubjectAccessReview POST before it knows whether the disk is an upload-source disk. Both hooks sit above the if (!isUploadSource(dv)) return null guard, so every VMDisk detail page pays for them, including disks that will never show the panel. The SSAR also goes out with namespace: "" when the namespace is not yet resolved.

Two halves, and they need different fixes.

The CDIConfig query can be gated on the DV load, but doing it naively makes things worse: CDIConfig then resolves after the DataVolume, so the panel renders once with the placeholder and flashes the "This cluster publishes no upload proxy URL" warning before the real value arrives. Any fix here has to hold the warning until CDIConfig has settled.

The SSAR half cannot be gated at all today. useSelfSubjectAccessReview takes only a spec and no options object, so there is no enabled to pass. That needs an enabled option added to the hook in @cozystack/k8s-client, which is why it was left out of #3847 rather than folded into an approved PR.

Raised by IvanHunters in review, deferred deliberately.

Activity

  1. added
    kind/cleanupCategorizes issue or PR as related to cleanup of code, process, or technical debt
    area/dashboardIssues or PRs related to the dashboard / UI
    triage/acceptedIndicates an issue is ready to be actively worked on
    priority/backlogGeneral backlog priority. Lower than priority/important-longterm
    and removed
    triage/needs-triageIndicates an issue needs triage by a maintainer
    on Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/dashboardIssues or PRs related to the dashboard / UIkind/cleanupCategorizes issue or PR as related to cleanup of code, process, or technical debtpriority/backlogGeneral backlog priority. Lower than priority/important-longtermtriage/acceptedIndicates an issue is ready to be actively worked on

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions