Skip to content

e2e: the dataplane capture leg's outer backstop is silent while the sibling leg reports INCOMPLETE #3657

Closed

Description

Summary

In hack/cozytest.sh, the two capture legs handle their outer bound differently. The previous-logs leg records its exit status and reports it: _prev_rc=$? and, on non-zero, "previous-instance capture INCOMPLETE (exit N); kept what landed in ..." (lines 111-124 at 605030b). The dataplane leg three stanzas later is timeout -k 30 600 .../e2e-capture-dataplane.sh ... || true (line 168): if the outer backstop kills the collector, nothing says so, and a truncated dataplane/ directory is indistinguishable from a complete one that found little.

Why it matters

The in-flight bounding work for the dataplane collector makes every read inside it name its own cutoff, which leaves exactly one way for that collector to die silently: the outer backstop at this call site. Closing it makes the collector's honesty contract complete end to end; leaving it open re-creates, one level up, the same "cut short reads as complete" gap the collector-level work removes.

Fix shape

Mirror the sibling leg: capture the exit status instead of || true, and on non-zero print an "INCOMPLETE (exit N); kept what landed" line naming the directory. Two lines, same discipline, same file.

Activity

  1. added
    kind/bugCategorizes issue or PR as related to a bug
    area/testingIssues or PRs related to testing (e2e, bats, unit tests)
    on Aug 8, 2026
  2. lexfrei commented on Sep 23, 2026

    @lexfrei
    ContributorAuthor

    Fixed by #3672. Both callers now report a capture cut short by the backstop: cozytest.sh prints data-plane capture INCOMPLETE (exit N), and a bats test covers the Chainsaw side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/testingIssues or PRs related to testing (e2e, bats, unit tests)kind/bugCategorizes issue or PR as related to a bugtriage/not-reproducibleIndicates an issue can not be reproduced as described

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions