Skip to content

immutable-paths: walker should descend into oneOf/anyOf/allOf branch properties #3101

Closed

Description

What

findImmutablePaths (apps/console/src/lib/immutable-paths.ts) recognises a parent as immutable when any oneOf/anyOf/allOf branch carries the CEL rule itself, but does NOT descend into a branch's own properties to discover per-field immutability inside the branch.

Why it matters

CRDs that use allOf for property composition (less common than direct properties, but legal and present in some upstream CRDs) won't have their inner immutable fields flagged. The UI will render those fields as editable and the overlay won't protect them.

Pinned

Current behaviour is pinned by the FIXME test in apps/console/src/lib/immutable-paths.test.ts ("FIXME: does NOT walk into properties beneath oneOf/anyOf/allOf branches"). Flip the assertion when the walker is extended.

Activity

  1. added
    kind/bugCategorizes issue or PR as related to a bug
    area/dashboardIssues or PRs related to the dashboard / UI
    on Jun 26, 2026
  2. myasnikovdaniil commented on Aug 15, 2026

    @myasnikovdaniil
    Contributor

    Closing as not reachable. Every oneOf/anyOf/allOf in the shipped application schemas is the int-or-string scalar pair, 134 of them, and none has properties, so the walker has no branch subtree to descend into. The console's own CLAUDE.md documents the gap as intentional. If a schema ever ships a branch that carries properties this becomes live again, and reopening is the right move then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/dashboardIssues or PRs related to the dashboard / UIkind/bugCategorizes issue or PR as related to a bugpriority/backlogGeneral backlog priority. Lower than priority/important-longtermtriage/acceptedIndicates an issue is ready to be actively worked on

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions