Skip to content

Missing values in extra/seaweedfs templates #2531

Closed

Description

@dvc

Describe the bug

Hi! I found 2 missed parameters:

  • filer.replicas
  • s3.replicas

Environment

  • Cozystack version: all
  • Provider: any

To Reproduce
Steps to reproduce the behavior:

  1. Create manifest SeaweedFS with custom values filer.replicas and/or s3.replicas
  2. Apply

Expected behaviour
helm release with custom values

Actual behaviour
Real values in helm release are defaults (2, 2)

Checklist

  • I have checked the documentation
  • I have searched for similar issues
  • I have included all required information
  • I have provided clear steps to reproduce
  • [] I have included relevant logs

Activity

  1. dosubot commented on Apr 29, 2026

    @dosubot

    Hi Chernosov Denis (@dvc)! I'm Dosu and I’m helping the cozystack team.

    Good catch! This is confirmed — the filer.replicas and s3.replicas values are defined in values.yaml [1] [2] and are referenced in the WorkloadMonitor resources [3] [4], but they are not interpolated into the HelmRelease spec.values section [5]. Other components like master, volume, and db correctly pass their replica counts [6] [7] [8], so filer and s3 are just missing the same pattern.

    The fix would be adding replicas: to the filer and s3 sections in the HelmRelease values:

    # filer section (~line 229)
    filer:
      replicas: {{ .Values.filer.replicas }}
      # ... existing config
    
    # s3 section (~line 238)
    s3:
      replicas: {{ .Values.s3.replicas }}
      # ... existing config

    This is also related to issue #2038 which tracks broader SeaweedFS value passthrough improvements [9].

    To reply, just mention @dosu.


    Docs are dead. Just use Dosu.

    Leave Feedback Ask Dosu about cozystack Share Dosu with your team

  2. added
    area/extraIssues or PRs related to tenant-specific modules (packages/extra/)
    area/storageIssues or PRs related to storage (linstor, seaweedfs, bucket, velero, harbor)
    triage/acceptedIndicates an issue is ready to be actively worked on
    priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release
    on Apr 29, 2026
  3. lexfrei commented on Apr 29, 2026

    @lexfrei
    Contributor

    Confirmed on main (6e045e69). The same .Values.*.replicas is referenced in two places, only one of which works:

    • HelmRelease spec.values.seaweedfs correctly passes replicas: for db (templates/seaweedfs.yaml:127), master (:140), and volume (:146) — but the filer block (:229-237) and s3 block (:238-253) omit it. So filer.replicas / s3.replicas from user values are silently dropped and the upstream chart defaults take over.
    • The WorkloadMonitor resources for filer (:284) and s3 (:378) do read .Values.filer.replicas / .Values.s3.replicas. As a second-order effect, when a user sets these values the monitor's expected replica count diverges from the actual deployment, which can trigger spurious alerts.

    Fix is straightforward — mirror the master/volume pattern and add replicas: {{ .Values.filer.replicas }} / replicas: {{ .Values.s3.replicas }} to the corresponding blocks in the HelmRelease values.

    Related (not a duplicate): #2038 tracks per-tenant SeaweedFS value passthrough at the Tenant chart level.

  4. added a commit that references this issue on May 1, 2026
    5ef1500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area/extraIssues or PRs related to tenant-specific modules (packages/extra/)area/storageIssues or PRs related to storage (linstor, seaweedfs, bucket, velero, harbor)kind/bugCategorizes issue or PR as related to a bugpriority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next releasetriage/acceptedIndicates an issue is ready to be actively worked on

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions