Repository navigation
fix(platform): bundle prologue swallows the document separator into the # Networking comment #2475
Description
Description
The top of packages/core/platform/templates/bundles/system.yaml is:
# Networking
{{- if eq .Values.bundles.system.variant "isp-full" }}
{{include "cozystack.platform.package" (list "cozystack.networking" "kubeovn-cilium" $ $networkingComponents) }}
...The {{- strips the newline after # Networking, and the first --- that the Package helper emits lands on the same line as the comment, producing # Networking---. YAML parses that as a pure comment — the document separator is lost.
Why it matters
Today it works because the isp-full variant block itself emits the first Package and there is nothing to collide with. The fragility only surfaces when a new Package include is added immediately before the # Networking line: the first emitted Package document's apiVersion merges into the previous Package's output and Flux's post-renderer fails with mapping key "apiVersion" already defined.
Hit this while adding a cozystack.gateway-api-crds include at the top of the bundle for #2470. I worked around it by moving the include into the Common Packages block, but the root cause is still there.
Fix options
- Remove the left-dash on
{{- if eq .Values.bundles.system.variant ...}}so the comment's trailing newline is preserved. - Emit an explicit
---line at the start of every Package helper's output.
Either fix is small. The first is less invasive; the second is defensive for any future include reshuffling.
Activity
docs(release): fix broken links and PR refs in v1.4.0 changelog (#2693)
docs(release): fix broken links and PR refs in v1.4.0 changelog
dosubot commentedon Jul 27, 2026
Hi, Aleksei Sviridkin (@lexfrei). I'm Dosu, and I'm helping the cozystack team manage their backlog and am marking this issue as stale.
Issue Summary
packages/core/platform/templates/bundles/system.yamlcan cause the# Networkingcomment to consume the first---document separator.apiVersionkeys.-from{{- if ... }}or ensure the package helper always emits an explicit---.Next Steps
Thanks for your understanding and contribution.
myasnikovdaniil commentedon Nov 6, 2026
Fixed on main, Package helper keeps a newline before the document separator, so the prologue renders as separate Package documents. It came with #4790, the dedicated #3751 was closed unmerged and no test pins this.