Repository navigation
Rewrite installer.sh on Go #11
Description
We have to rewrite main installer.sh script, and all our Makefiles in Go
Makefiles should not be used for deploying applications, only for updating manifests and building images
Up to discussion:
What about keepeng the version migrators to be language unspecific? - so they cloud be just executable files in some directory.
Or is there any common practicies for that?
Metadata
Metadata
Assignees
Labels
No labels
Activity
[-]Rewrite `installer.sh` and Makefiles on Go[/-][+]Rewrite `installer.sh` on Go[/+]s3rj1k commentedon Feb 18, 2024
A little bit of digging in, doing quick PoC basically revealed that there is no sane reason to rewrite few bash lines in Golang or even any other compiled language, it will bring distribution complexity and solve nothing.
This will probably be a good choice in case of script being a bit more complicated and having some ncurses UI in it, for this specific one I would recommend leaving it as is.
Also we should consider removing
https://github.com/aenix-io/cozystack/blob/main/scripts/installer.sh#L39-L41this code in favor of more k8s-like approach. (#18)For the sake of bringing more context, we are not the only ones that struggle with
BashvsUniversequestion, check out this link also: https://dev.to/jmfayard/bash-is-a-terrible-programming-language-but-whats-the-alternative--oc2kvaps commentedon Feb 18, 2024
Thank you a lot for your research, Serhii Ivanov (@s3rj1k) 👍
We designed Cozystack to minimize the imperative logic as much as possible.
Closing for now. I believe if the need ever arises in the future due to increased complexity, we can always come back to this issue.
I've opened a new issue for moving redis reloading logic outside of
installer.shscript #19cozyplane: pin the SG v2 build (RPF, #11, floating-egress gate)
cozyplane: pin the SG v2 build (RPF, #11, floating-egress gate)
cozyplane: pin the SG v2 build (RPF, #11, floating-egress gate)
cozyplane: pin the SG v2 build (RPF, #11, floating-egress gate)