Skip to content

Commit ff7c8fa

Browse files
myasnikovdaniilclaude
myasnikovdaniil
and
claude
committed
fix(dashboard): guard empty COZYSTACK_VERSION in the console APP_VERSION build-arg
Address non-blocking review feedback from lexfrei on packages/system/dashboard/Makefile:34. When COZYSTACK_VERSION is empty (a local build with no matching git tag) the build-arg baked a bare `APP_VERSION=v` into the console bundle. Match the guard the root Makefile already uses for platformVersion so an empty version yields an empty APP_VERSION instead of "v". Dev-only cosmetics — the config.json path overrides the displayed version at deploy time — but it removes the mismatch. Co-Authored-By: Claude Fable 5 <[email protected]> Signed-off-by: Myasnikov Daniil <[email protected]>
1 parent 8aebc34 commit ff7c8fa

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎packages/system/dashboard/Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ build-console:
3131
$(call image-tags,cozystack-ui,v$(COZYSTACK_VERSION)) \
3232
$(call cache-args,cozystack-ui) \
3333
--metadata-file images/console.json \
34-
--build-arg APP_VERSION=v$(COZYSTACK_VERSION) \
34+
--build-arg APP_VERSION=$(if $(COZYSTACK_VERSION),v$(COZYSTACK_VERSION),) \
3535
--push=$(PUSH) \
3636
--label "org.opencontainers.image.source=https://github.com/cozystack/cozystack" \
3737
--load=$(LOAD)

0 commit comments

Comments
 (0)