Skip to content

Commit f7279b6

Browse files
test(e2e): quote HelmRelease names in kubectl wait
Both \${test_name} and \${component} are literal-safe today (no whitespace, no glob characters), so this is a style-only change — but quoting variable expansions in kubectl arguments matches the rest of the file and removes a future-foot-gun if a test name ever grows a hyphen-y suffix that interacts oddly with completion or globbing. Scoped to the two HelmRelease wait lines flagged by CodeRabbit and echoed by the human reviewer; the machinedeployment wait on the preceding line keeps its existing style. Assisted-By: Claude <[email protected]> Signed-off-by: Myasnikov Daniil <[email protected]>
1 parent 09883f4 commit f7279b6

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎hack/e2e-apps/run-kubernetes.sh‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -358,9 +358,9 @@ EOF
358358
kubectl wait machinedeployment kubernetes-${test_name}-md0 -n tenant-test --timeout=10m --for=jsonpath='{.status.v1beta2.readyReplicas}'=2
359359

360360
for component in cilium coredns csi vsnap-crd; do
361-
kubectl wait hr kubernetes-${test_name}-${component} -n tenant-test --timeout=5m --for=condition=ready
361+
kubectl wait hr "kubernetes-${test_name}-${component}" -n tenant-test --timeout=5m --for=condition=ready
362362
done
363-
kubectl wait hr kubernetes-${test_name}-ingress-nginx -n tenant-test --timeout=5m --for=condition=ready
363+
kubectl wait hr "kubernetes-${test_name}-ingress-nginx" -n tenant-test --timeout=5m --for=condition=ready
364364

365365
# Optional ouroboros addon assertions. Folded in from the standalone
366366
# ouroboros.bats so the test reuses this cluster instead of spinning up a

0 commit comments

Comments
 (0)