Skip to content

Commit f5961ae

Browse files
myasnikovdaniilmyasnikovdaniil
committed
fix(console): stop promising an in-page upload on the VMDisk form
Picking the `upload` source told the user "you can upload an image using the UI or virtctl command". There has never been a UI for it, and there cannot be one: the browser has no route to CDI's upload proxy that can carry the upload token (see the preceding commit). Say what actually happens instead, and point at the command the disk's own page now shows. Signed-off-by: Myasnikov Daniil <[email protected]>
1 parent cf0f0b8 commit f5961ae

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

‎packages/system/dashboard/images/console/apps/console/src/components/SourceField.tsx‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,9 @@ export function SourceField(props: FieldProps) {
9292
</p>
9393
{option === "upload" && (
9494
<p className="text-xs text-blue-600 mt-2">
95-
After creating the disk, you can upload an image using the UI or virtctl command.
95+
After creating the disk, upload the image with the virtctl command shown
96+
on the disk's page. Browsers cannot reach the CDI upload proxy, so there
97+
is no in-page upload.
9698
</p>
9799
)}
98100
</div>

‎packages/system/dashboard/images/console/apps/console/src/components/SourceWidget.tsx‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@ export function SourceWidget(props: WidgetProps) {
5555
</p>
5656
{option === "upload" && (
5757
<p className="text-xs text-blue-600 mt-2">
58-
After creating the disk, you can upload an image using the UI or virtctl command.
58+
After creating the disk, upload the image with the virtctl command shown
59+
on the disk's page. Browsers cannot reach the CDI upload proxy, so there
60+
is no in-page upload.
5961
</p>
6062
)}
6163
</div>

0 commit comments

Comments
 (0)