Repository navigation
Commit f11bd3b
committed
test(e2e): pin what the line-match case can actually catch
Review found the case named "line match is dot-anchored (1.5 does not
match v155.x)" does not test that: removing the `sed 's/\./\\./g'`
escaping from latest_on_line leaves all ten cases green.
Checked it, and the reason is narrower than the report. Over the tags
stable_desc emits — `^v[0-9]+\.[0-9]+\.[0-9]+$` and nothing else — the
escaping, the trailing `$` and the `^` are each unfalsifiable: such a tag
carries exactly one `v` and it is at the front, so no fixture can be
built that the escaped and unescaped patterns disagree about. v155.0.0
in particular matches neither reading, so the old fixture pinned nothing
at all.
One piece of the anchoring a fixture CAN reach is the leading `^v` pair.
v11.5.0 ends in "1.5.0" and `sort -rV` puts it above v1.5.3, so a
pattern that has lost that prefix resolves the wrong line entirely.
Swap the fixture to it, rename the case to the property it now pins, and
record in both files what is and is not falsifiable here, so the next
reader does not have to redo the experiment.
Verified non-vacuous: dropping `^v` from latest_on_line's pattern turns
exactly this case red; the other ten stay green.
Assisted-By: Claude <[email protected]>
Signed-off-by: Myasnikov Daniil <[email protected]>1 parent a9e39c9 commit f11bd3b
2 files changed
Lines changed: 24 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
40 | 46 | | |
41 | 47 | | |
42 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
96 | 110 | | |
97 | 111 | | |
98 | 112 | | |
99 | | - | |
| 113 | + | |
100 | 114 | | |
101 | 115 | | |
102 | 116 | | |
| |||
0 commit comments