Skip to content

Commit eec069b

Browse files
authored
docs(kubevirt): name every payload line the tail checks do not cover (#4340)
## What this PR does Follow-up to a review comment on #4254 that was right and landed after the merge. The sentence that PR left in `packages/system/kubevirt/Makefile` says the device and CPU payload lines stay outside the marker checks, which reads as if the rest are handled. The `- {{ . }}` entries inside the `extraFeatureGates` and `disabledFeatureGates` ranges are neither device nor CPU and are not covered either. Deleting either of them from a copy of the CR and running `make update CR_FILE=<copy>` exits 0 and leaves the range wrapped around nothing, with no check firing; dropping `- Template` from a clean copy fails the target as a control. The wording now names every uncovered payload line: the device tables, the `cpuAllocationRatio` value and both feature-gate entries, and keeps `migrations` as the one block validated whole. Covering those payloads in code is a wider change; happy to do it separately if that is wanted. ### Screenshots Not a UI change. ### Downstream repositories Comment-only change in one Makefile. - [x] No downstream repository is affected by this change ### Release note ```release-note NONE ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Clarified update validation guidance for disabled-feature markers. * Documented partial-block recovery requirements and the workflow for restoring missing markers. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 parents 89da4a1 + b6ed32c commit eec069b

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

‎packages/system/kubevirt/Makefile‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,14 @@ update:
7272
@# for, and their absence cannot surface as a value that stopped taking
7373
@# effect — the CR simply goes back to deploying virt-template, to letting
7474
@# KubeVirt skip NAD resource injection, and to image volumes an apiserver
75-
@# below 1.35 discards. The device/CPU payload lines remain outside these
76-
@# checks; migrations validates its complete block below. `make update` cannot
77-
@# repair a partial block — the directive guard is what stops the insert — so
78-
@# name the missing marker and let the operator restore it.
75+
@# below 1.35 discards. Every other payload line stays outside these checks:
76+
@# the device tables, the cpuAllocationRatio value, and the `- {{ . }}` entry
77+
@# inside each of the extraFeatureGates and disabledFeatureGates ranges, whose
78+
@# deletion leaves `make update` exiting 0 with the range wrapped around
79+
@# nothing. migrations is the one block validated whole, below.
80+
@# `make update` cannot repair a partial block — the directive guard is what
81+
@# stops the insert — so name the missing marker and let the operator restore
82+
@# it.
7983
@grep -q '{{- if .Values.cpuAllocationRatio }}' $(CR_FILE) || { echo "ERROR: directive '{{- if .Values.cpuAllocationRatio }}' not inserted — restore the 'developerConfiguration:' anchor in $(CR_FILE) and re-run" >&2; exit 1; }
8084
@grep -q '{{- range .Values.extraFeatureGates }}' $(CR_FILE) || { echo "ERROR: directive '{{- range .Values.extraFeatureGates }}' not inserted — restore the '- VMExport' anchor in $(CR_FILE) and re-run" >&2; exit 1; }
8185
@grep -q '{{- range .Values.disabledFeatureGates }}' $(CR_FILE) || { echo "ERROR: directive '{{- range .Values.disabledFeatureGates }}' not inserted — restore the 'featureGates:' anchor in $(CR_FILE) and re-run" >&2; exit 1; }

0 commit comments

Comments
 (0)