Repository navigation
Commit eec069b
authored
docs(kubevirt): name every payload line the tail checks do not cover (#4340)
## What this PR does
Follow-up to a review comment on #4254 that was right and landed after
the merge.
The sentence that PR left in `packages/system/kubevirt/Makefile` says
the device and CPU payload lines stay outside the marker checks, which
reads as if the rest are handled. The `- {{ . }}` entries inside the
`extraFeatureGates` and `disabledFeatureGates` ranges are neither device
nor CPU and are not covered either. Deleting either of them from a copy
of the CR and running `make update CR_FILE=<copy>` exits 0 and leaves
the range wrapped around nothing, with no check firing; dropping `-
Template` from a clean copy fails the target as a control.
The wording now names every uncovered payload line: the device tables,
the `cpuAllocationRatio` value and both feature-gate entries, and keeps
`migrations` as the one block validated whole. Covering those payloads
in code is a wider change; happy to do it separately if that is wanted.
### Screenshots
Not a UI change.
### Downstream repositories
Comment-only change in one Makefile.
- [x] No downstream repository is affected by this change
### Release note
```release-note
NONE
```
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Documentation**
* Clarified update validation guidance for disabled-feature markers.
* Documented partial-block recovery requirements and the workflow for
restoring missing markers.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->1 file changed
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
79 | 83 | | |
80 | 84 | | |
81 | 85 | | |
| |||
0 commit comments