Repository navigation
Commit eea8b73
authored
feat(kubernetes): per-node-group nodeHealthCheck overrides (#3053)
Adds per-node-group overrides for the worker MachineHealthCheck tuning
introduced as a cluster-wide `nodeHealthCheck` by #2931.
**What:** optional `nodeGroups[name].maxUnhealthy` and
`nodeGroups[name].nodeStartupTimeout`; when unset a group inherits the
cluster-wide `nodeHealthCheck.*` (no behaviour change). The per-group
value reuses the existing int-or-string validation; an invalid override
fails the render naming the offending group.
**Why:** the MachineHealthCheck is rendered per node group, so groups
can warrant different remediation tolerances (e.g. a stateful group at
`0%`, stateless at `50%`). This is the per-group granularity of the
standalone proposal (#2752 / #2935), rebuilt on top of #2931's
`nodeHealthCheck`.
**Notes:** stacked on `phase1-talos-migration` (#2931) — retarget to
`main` once it merges. Supersedes #2935 (original author credited as
co-author). helm-unittest covers per-group override (percent + bare
int), `nodeStartupTimeout` override, fallback-when-unset, and
invalid-override rejection.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Added per-node-group overrides for health-check settings:
`maxUnhealthy` and `nodeStartupTimeout`, with automatic fallback to
cluster-wide `nodeHealthCheck` when unset.
* **Bug Fixes**
* Improved `maxUnhealthy` parsing/rendering to support both bare
integers and percentage strings, including more precise validation
errors for the exact override path.
* **Documentation**
* Updated kubernetes app docs and values schemas (including CRD
chart-values schema) to document the new override fields.
* **Tests**
* Added MachineHealthCheck rendering tests for override, fallback, and
invalid `maxUnhealthy` (e.g., `"abc"`) cases.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->7 files changed
Lines changed: 116 additions & 5 deletions
File tree
- api/apps/v1alpha1/kubernetes
- packages
- apps/kubernetes
- templates
- tests
- system/kubernetes-rd/cozyrds
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| 132 | + | |
| 133 | + | |
132 | 134 | | |
133 | 135 | | |
134 | 136 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
815 | 815 | | |
816 | 816 | | |
817 | 817 | | |
818 | | - | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
819 | 821 | | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
820 | 827 | | |
821 | 828 | | |
822 | | - | |
| 829 | + | |
823 | 830 | | |
824 | 831 | | |
825 | 832 | | |
826 | 833 | | |
827 | 834 | | |
828 | | - | |
| 835 | + | |
829 | 836 | | |
830 | | - | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
831 | 840 | | |
832 | 841 | | |
833 | 842 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
110 | 114 | | |
111 | 115 | | |
112 | 116 | | |
113 | 117 | | |
114 | 118 | | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
115 | 123 | | |
116 | 124 | | |
117 | 125 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| 91 | + | |
| 92 | + | |
91 | 93 | | |
92 | 94 | | |
93 | 95 | | |
| |||
Large diffs are not rendered by default.
0 commit comments