Skip to content

Commit ecdc043

Browse files
scooby87lexfrei
scooby87
authored and
lexfrei
committed
build(seaweedfs): keep Renovate and git whitespace off the in-tree build
Renovate would bump the builder, the base image or their digests one at a time into a combination upstream never shipped, and the next `make update` would silently put them back, so it leaves that Dockerfile to the update recipe. The patches are unified diffs of Go sources, whose context lines start with a marker before tabs and blank lines, which git's whitespace checks would otherwise flag or rewrite. Assisted-by: LLM Signed-off-by: Alexey Artamonov <[email protected]>
1 parent 5592a3f commit ecdc043

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

‎.gitattributes‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
# Unified diff context has a marker before Go tabs and blank lines.
22
packages/system/capi-providers-infraprovider/images/cluster-api-provider-kubevirt/patches/*.diff -whitespace
33
packages/system/cilium/images/cilium-operator/patches/*.diff -whitespace
4+
packages/system/seaweedfs/images/seaweedfs/patches/*.diff -whitespace

‎.github/renovate.json‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,12 @@
100100
"matchUpdateTypes": ["major", "minor"],
101101
"enabled": false
102102
},
103+
{
104+
"description": "The seaweedfs rebuild compiles one upstream release with the Go toolchain upstream's docker/Dockerfile.go_build uses at that tag, lays it over the upstream image of that tag, and `make update` in packages/system/seaweedfs re-pins the builder, the base image digest and the source checksum from there. A Renovate bump of any of them builds a combination upstream never shipped, and the next `make update` silently reverts it. Updates are disabled here; all of them move with the SeaweedFS version.",
105+
"matchManagers": ["dockerfile"],
106+
"matchFileNames": ["packages/system/seaweedfs/images/seaweedfs/**"],
107+
"enabled": false
108+
},
103109
{
104110
"description": "kubevirt.io/csi-driver is pinned to an untagged pseudo-version commit and publishes no release tags, so Renovate's go datasource returns no-result and the lookup failure lingers on the Dependency Dashboard. Disable it; this module is advanced deliberately alongside the kubevirt-csi-driver image build.",
105111
"matchManagers": ["gomod"],

0 commit comments

Comments
 (0)