Repository navigation
Commit dc56658
committed
feat(kubernetes): tie kubevirt-csi's VMI hotplug fallback to the gate
The right value of --enable-vmi-hotplug-fallback is decided by the
KubeVirt CR in packages/system/kubevirt, not by the tenant: it must stay
true while that CR enables HotplugVolumes and turn false in the same
change that drops the gate. A note beside the gate in the CR points at
the controller Deployment, and a helm-unittest pins the flag off the
rendered args.
The chart relies on the driver default instead of rendering =true. The
driver image is stamped only at release preparation, so between
releases the chart on main runs the previous release's binary, which
does not know the flag, and Go's flag package exits on an unknown one:
rendering the default would crash-loop the controller for no effect.
Assisted-by: LLM
Signed-off-by: Aleksei Sviridkin <[email protected]>1 parent a54e821 commit dc56658
2 files changed
Lines changed: 36 additions & 0 deletions
File tree
- packages
- apps/kubernetes/tests
- system/kubevirt/templates
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| 104 | + | |
| 105 | + | |
104 | 106 | | |
105 | 107 | | |
106 | 108 | | |
| |||
0 commit comments