Repository navigation
Commit d7f3f0d
authored
fix(hack): keep root monitoring redirects off in the E2E install (#4811)
## What this PR does
This fixes the E2E install on pull requests that select only a few
suites. Today those runs fail before any suite starts:
`cozystack-basics` fails with `namespaces "cozy-monitoring" not found`,
and every package waiting on basics never installs.
The reduced install from #4022 disables every package the selected
suites don't need. For narrow selections like `vminstance` or the
Kubernetes suites, that list includes metrics-server, monitoring-agents
and monitoring, which are the only packages that create
`cozy-monitoring`. Basics still renders three ExternalName redirects
into that namespace, because `monitoring.rootEnabled` stays at its
default of true. Wide selections keep at least one of those packages, so
they pass.
The E2E install already sets `Tenant/root spec.monitoring` to false, and
`rootEnabled` is meant to match it. The harness now sets `rootEnabled:
false`, so basics no longer writes into a namespace the install may not
create. No suite uses these redirects. With root monitoring off they
pointed at nothing even on full runs.
The same failure can happen in a real cluster when a user disables those
three packages. That needs a product change and is tracked in #4810.
### Screenshots
### Downstream repositories
- [x] No downstream repository is affected by this change
- [ ] [cozystack/website](https://github.com/cozystack/website) -
follow-up:
- [ ]
[cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack)
- follow-up:
- [ ]
[cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack)
- follow-up:
- [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up:
- [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up:
- [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) -
follow-up:
- [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) -
follow-up:
- [ ]
[cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server)
- follow-up:
- [ ]
[cozystack/external-apps-example](https://github.com/cozystack/external-apps-example)
- follow-up:
- [ ] [cozystack/examples](https://github.com/cozystack/examples) -
follow-up:
- [ ] [cozystack/community](https://github.com/cozystack/community) -
follow-up:
### Release note
```release-note
fix(hack): the E2E install keeps root monitoring redirects off, so runs that select only a few suites no longer fail on a missing cozy-monitoring namespace.
```
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Bug Fixes**
* Root monitoring stays disabled in generated platform package settings
when `cozy-monitoring` is omitted, preventing monitoring Services from
being rendered in narrowly selected test suites.
* **Documentation**
* Clarified how the root monitoring setting relates to the
installation’s `Tenant/root` configuration and which setting to change
to enable it.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->3 files changed
Lines changed: 19 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
275 | 275 | | |
276 | 276 | | |
277 | 277 | | |
278 | | - | |
| 278 | + | |
| 279 | + | |
279 | 280 | | |
280 | 281 | | |
281 | 282 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
71 | 76 | | |
72 | 77 | | |
73 | 78 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
150 | 162 | | |
151 | 163 | | |
152 | 164 | | |
| |||
0 commit comments