Skip to content

Commit cc7d09b

Browse files
committed
fix(tests): use far-future cron in etcd backup e2e to avoid job churn
Address review feedback from coderabbitai on hack/e2e-apps/etcd.bats:89: the test verifies that the chart renders EtcdBackupSchedule and that the etcd-operator materializes a CronJob, not that backups fire. Use "0 0 1 1 *" so no Jobs run against the intentionally invalid endpoint during the ~6-minute test window. Assisted-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>
1 parent 97eef02 commit cc7d09b

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

‎hack/e2e-apps/etcd.bats‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,12 @@ spec:
8686
memory: 128Mi
8787
backup:
8888
enabled: true
89-
schedule: "*/1 * * * *"
90-
# This test verifies that the chart renders EtcdBackupSchedule/Secret and
91-
# that the etcd-operator materializes a CronJob from the schedule — it does
92-
# NOT verify that backups reach S3. The endpoint below intentionally
93-
# resolves nowhere to keep the test self-contained.
89+
# Schedule is chosen far in the future so no Jobs fire during the
90+
# ~6-minute test window; this test only checks that the chart renders
91+
# EtcdBackupSchedule/Secret and that the etcd-operator materializes a
92+
# CronJob — it does NOT verify that backups reach S3. The endpoint
93+
# below intentionally resolves nowhere to keep the test self-contained.
94+
schedule: "0 0 1 1 *"
9495
destinationPath: "s3://test-bucket/etcd-backups/"
9596
endpointURL: "http://no-such-endpoint.invalid:9000"
9697
region: "us-east-1"

0 commit comments

Comments
 (0)