Skip to content

Commit cc7551c

Browse files
test(e2e): use $name in kafka.bats kubectl wait (review feedback PR #2554)
Address lexfrei's nit on PR #2554: the pre-existing `kubectl wait kafkas -n tenant-test test ...` on line 47 hardcoded the resource name, while the existence backstop one line above was already parametrized with `$name` in 12ccc53. Switch the wait to `$name` for consistency so changing the test's resource name in one place keeps the two lines aligned. Signed-off-by: Myasnikov Daniil <[email protected]>
1 parent 12ccc53 commit cc7551c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎hack/e2e-apps/kafka.bats‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ EOF
4444
timeout 60 sh -ec "until kubectl -n tenant-test get hr kafka-$name >/dev/null 2>&1; do sleep 2; done"
4545
kubectl -n tenant-test wait hr kafka-$name --timeout=30s --for=condition=ready
4646
timeout 60 sh -ec "until kubectl -n tenant-test get kafkas $name >/dev/null 2>&1; do sleep 2; done"
47-
kubectl wait kafkas -n tenant-test test --timeout=300s --for=condition=ready
47+
kubectl wait kafkas -n tenant-test $name --timeout=300s --for=condition=ready
4848
timeout 60 sh -ec "until kubectl -n tenant-test get pvc data-kafka-$name-zookeeper-0; do sleep 10; done"
4949
kubectl -n tenant-test wait pvc data-kafka-$name-zookeeper-0 --timeout=50s --for=jsonpath='{.status.phase}'=Bound
5050
timeout 40 sh -ec "until kubectl -n tenant-test get svc kafka-$name-zookeeper-client -o jsonpath='{.spec.ports[0].port}' | grep -q '2181'; do sleep 10; done"

0 commit comments

Comments
 (0)