Repository navigation
Commit c77616a
committed
test(release): pin the audit's label set to the one the backport bot acts on
cmd/backport-audit finds its candidates with `gh pr list --label`,
which matches by exact name, so the label set is a contract between it
and backport.yaml that nothing else couples. When the labels were
namespaced under kind/, backport.yaml was updated in lockstep and the
audit was not. Nothing errored: `--label backport` went on matching and
returned 7 of the 290 merged PRs carrying a request, so the audit
reported two branches clean that between them had 5 missing and 7
pending backports, and exited 0.
That is the failure mode this file already exists to prevent for the
workflows themselves -- an invariant whose first report otherwise
arrives at a real release, on the commit nobody wants to be debugging.
A rename is worse than the cases already pinned here, because it breaks
nothing loudly at all.
Pin the two sets equal rather than either one's contents. The audit
must not miss a spelling the bot honours, and must not keep one the bot
has retired: the legacy names are transitional, and the two files have
to drop them together.
The extraction reads the bot's label-detection script and the audit's
Go string literals. The audit's own prose quotes these names with
backticks rather than double quotes, so a comment cannot satisfy the
pin. Verified by mutation: dropping one legacy spelling from the audit
alone turns the test red.
Assisted-By: Claude <[email protected]>
Signed-off-by: Myasnikov Daniil <[email protected]>1 parent 2dd2296 commit c77616a
1 file changed
Lines changed: 43 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| 23 | + | |
22 | 24 | | |
23 | 25 | | |
24 | 26 | | |
| |||
594 | 596 | | |
595 | 597 | | |
596 | 598 | | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
0 commit comments