Skip to content

Commit c4e53f9

Browse files
committed
docs(observability-proxy): name every query form the app 422 refuses
The refusal named only the @ modifier and non-literal offsets, but the same answer covers an @ inside a label value and WITH with a negative offset, so a client could not tell why such a query was refused. Assisted-by: LLM Signed-off-by: ZverGuy <[email protected]>
1 parent 7153282 commit c4e53f9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎internal/observabilityproxy/appscope.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ func applicationSelectors(ns, kind, name string, pods, pvcs []string) []string {
102102
// application's series.
103103
func (s *Server) applicationScope(ctx context.Context, r *http.Request, store string, req metricsRequest, ns, kind, name string) ([]string, *HTTPError) {
104104
if req.last.IsZero() {
105-
return nil, errorf(http.StatusUnprocessableEntity, "the query reads samples at a time the application scope cannot cover (an @ modifier, or an offset that is not a plain duration); use the namespace root")
105+
return nil, errorf(http.StatusUnprocessableEntity, "the query reads samples at a time the application scope cannot cover (an @ anywhere in the query, WITH with a negative offset, or an offset that is not a plain duration); use the namespace root")
106106
}
107107
lim := s.cfg.Metrics.App
108108
if req.start.IsZero() || req.start.Before(req.from.Add(-lim.Lookback)) {

0 commit comments

Comments
 (0)