Repository navigation
Commit be85ee0
committed
fix(dashboard): treat a blank logoHeight as unset, not zero
Review follow-up (non-blocking). A blank branding.logoHeight survives pick into config.json, and Number("") is 0, which passed the finite check and clamped to the 16px minimum instead of the 36px default. Trim blank strings to NaN so they fall back to the default. Also fix a stale comment in SchemaForm that still described the old ["number", "string"] shape after the switch to ["string", "integer"].
Assisted-by: LLM
Signed-off-by: IvanHunters <[email protected]>1 parent bb50cb4 commit be85ee0
3 files changed
Lines changed: 13 additions & 2 deletions
File tree
- packages/system/dashboard/images/console
- apps/console/src
- __tests__
- components
- packages/ui/src/components/layout
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
43 | 52 | | |
44 | 53 | | |
45 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
311 | 311 | | |
312 | 312 | | |
313 | 313 | | |
314 | | - | |
| 314 | + | |
315 | 315 | | |
316 | 316 | | |
317 | 317 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
39 | 41 | | |
40 | 42 | | |
41 | 43 | | |
| |||
0 commit comments