Skip to content

Commit ba67fea

Browse files
myasnikovdaniilmyasnikovdaniil
committed
ci(release): drop paths-ignore from the release finalize trigger
The promote PR now carries docs/changelogs/vX.Y.Z.md, and Prepare stable branch explicitly tolerates producing no tag-string changes when the digests are already stable. Together those can yield a docs-only promote PR, which `paths-ignore: docs/**/*` would filter out — finalize never runs, so the stable tag is never cut and the release is never published, with no error raised anywhere. The `if:` gate (merged + `release` label + release-bot author) is what actually decides whether this workflow does anything, so let it do the filtering. The cost is a skipped job on unrelated closed PRs. Signed-off-by: Myasnikov Daniil <[email protected]>
1 parent 75b5192 commit ba67fea

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

‎.github/workflows/pull-requests-release.yaml‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,15 @@ name: "Releasing PR"
33
on:
44
pull_request:
55
types: [closed]
6-
paths-ignore:
7-
- 'docs/**/*'
6+
# No paths filter. A `paths-ignore: docs/**/*` used to live here as an
7+
# optimization, but the promote PR now carries docs/changelogs/vX.Y.Z.md —
8+
# and `Prepare stable branch` explicitly tolerates producing no tag-string
9+
# changes ("digests already stable"). That combination can yield a docs-only
10+
# promote PR, which the filter would drop: no finalize run, so no tag, no
11+
# release, and no error anywhere. Filtering is left entirely to the `if:`
12+
# gate below (merged + `release` label + release-bot author), which is what
13+
# actually decides whether this workflow should do anything. The cost is a
14+
# skipped job on unrelated closed PRs.
815

916
# Cancel in‑flight runs for the same PR when a new push arrives.
1017
concurrency:

0 commit comments

Comments
 (0)