You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b89a18b
Browse filesBrowse the repository at this point in the historyBrowse files
test(e2e): sharpen round-trip diagnostics and make teardown settle
Recommendations from the third review pass (which returned LGTM; none of these
blocked, all three are cheap and make the failure paths honest).
1. The round-trip's catch named nothing. An unnamed `describe HelmRelease` in
tenant-root dumps every release on the root tenant of a live cluster and
buries the two that matter, so name them (mariadb-2-backup-roundtrip names
its release for the same reason). Raised podLogs tail 100 -> 200, since the
sidecar logs every action and an S3 error sits well back from the tail by the
time a step fails, and added the Keeper Pods: chkeeper.yaml labels them
`app: <release>-keeper`, so the existing app.kubernetes.io/instance selectors
missed them entirely — and a source ClickHouse that never reaches a ready
replica is usually Keeper failing to form a quorum, which explains itself
only there.
2. SSL_CERT_DIR is now `/etc/ssl/cozy-s3-ca:/etc/ssl/certs`. The single-directory
form works — Go reads the default bundle FILE regardless, which is what the
earlier measurement showed — but that left the public-CA half of the contract
resting on a file this image happens to ship. Naming the system directory
costs nothing and survives a base-image bump that moves the bundle; verified
against public AWS S3 that both forms still verify (403 auth, no x509). The
mount path stays the bare directory, and the unit test now pins both halves
separately — it caught the over-broad edit that had briefly made mountPath a
colon list.
3. cleanup.sh returned while the uninstalls it triggered were still running, so
the next suite (etcd) could start with helm-controller still draining this
one, and the pre-clean could hand step 04 an application whose predecessor
was still going away. It now waits for both ClickHouse releases and the
Bucket to actually disappear, and — since the script deliberately runs
without `set -e` so one absent resource cannot abandon the rest — records
those failures and exits non-zero, rather than reporting a teardown that did
not settle as success. wait_deleted polls `get` instead of using
`kubectl wait --for=delete`, which errors on an already-absent resource: the
normal case here, and indistinguishable from a real failure.
Sized the two cleanup step budgets to 12m for the same reason the run step is
60m: cleanup.sh's waits now sum to 540s, which the previous 8m did not clear.
The Keeper-sized-from-the-server-resources bug the review found outside this
diff is filed as #3487.
Assisted-By: Claude <[email protected]>
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Signed-off-by: Andrey Kolkov <[email protected]>
log_error "Cleanup did not settle: see the resources reported above. Failing rather than leaving a half-uninstalled release for the next test to trip over."
0 commit comments