Skip to content

Commit b81e92a

Browse files
ci(tests): remove redundant Release E2E workflow
The Release E2E workflow (`release-e2e.yaml`) ran the full bats suite on every release tag as a non-blocking alarm — its own header notes "a failure here is an alarm, not a release blocker." It duplicates coverage the release-cut PR already provides: the "Prepare release" commit bakes image digests into `packages/core/` (and other packages), which TIA escalates to the full suite, so the release PR exercises the whole suite against the commit the tag will point at. It has also never been green since it was added (2026-05-02): every tag run failed at the build step. Even after #2973 fixed the registry login today, the next run still failed (Build Talos image). Removing a perpetually-red, non-gating duplicate removes noise without losing coverage. Removes the workflow, drops `release-e2e` from `select-e2e.sh`'s full-suite pattern, repoints its unit test to `pull-requests.yaml`, and updates the e2e-testing doc. Refs #2397 Assisted-By: Claude <[email protected]> Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Signed-off-by: Myasnikov Daniil <[email protected]>
1 parent 77d42ab commit b81e92a

4 files changed

Lines changed: 5 additions & 174 deletions

File tree

‎.github/workflows/release-e2e.yaml‎

Lines changed: 0 additions & 169 deletions
This file was deleted.

‎docs/agents/e2e-testing.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# E2E Testing Conventions
22

3-
Guidance for writing, changing, and reviewing Cozystack's end-to-end (E2E) tests and the CI that runs them. Read this **before** touching anything under `hack/e2e-apps/`, `hack/e2e-*.bats`, `hack/*.sh` test helpers, the E2E CI workflows (`.github/workflows/pull-requests.yaml`, `.github/workflows/release-e2e.yaml`), or `packages/core/testing/`.
3+
Guidance for writing, changing, and reviewing Cozystack's end-to-end (E2E) tests and the CI that runs them. Read this **before** touching anything under `hack/e2e-apps/`, `hack/e2e-*.bats`, `hack/*.sh` test helpers, the E2E CI workflow (`.github/workflows/pull-requests.yaml`), or `packages/core/testing/`.
44

55
## The core principle
66

@@ -59,7 +59,7 @@ A parent HelmRelease that hit its wait timeout, uninstalled, and reinstalled is
5959

6060
- Conservative escalation: edits to `packages/library/`, `packages/core/`, `api/`, `cmd/`, `internal/`, shared `hack/*.sh|*.bats` helpers, the `Makefile`, or the E2E workflows escalate to the **full suite**. A per-app bats edit selects **only** that app.
6161
- The `full-e2e` PR label forces the whole suite.
62-
- Companion: `.github/workflows/release-e2e.yaml` runs the **full** suite on every release tag, closing the coverage gap TIA opens on PRs.
62+
- The coverage gap TIA opens on PRs is closed at release-cut time: the "Prepare release" commit bakes image digests into `packages/core/` (and other packages), which TIA escalates to the **full** suite — so the release PR exercises the whole suite against the commit the tag will point at.
6363

6464
When adding a new app package, confirm `select-e2e.sh` maps it correctly (it has a unit test, `hack/select-e2e_test.bats`).
6565

‎hack/select-e2e.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ SOURCES_DIR="${2:-packages/core/platform/sources}"
1919
# Anything matching this pattern triggers the full bats suite. Per-app bats
2020
# (hack/e2e-apps/<name>.bats) are matched BEFORE this so editing one bats
2121
# file doesn't escalate to the full suite.
22-
full_suite_pattern='^(packages/library/|packages/core/|api/|cmd/|internal/|hack/[^/]+\.sh$|hack/[^/]+\.bats$|hack/e2e-apps/[^/]+\.sh$|Makefile$|\.github/workflows/(pull-requests|release-e2e)\.yaml$)'
22+
full_suite_pattern='^(packages/library/|packages/core/|api/|cmd/|internal/|hack/[^/]+\.sh$|hack/[^/]+\.bats$|hack/e2e-apps/[^/]+\.sh$|Makefile$|\.github/workflows/pull-requests\.yaml$)'
2323

2424
# All known per-app bats files
2525
all_apps=$(ls hack/e2e-apps/*.bats 2>/dev/null | xargs -n1 basename | sed 's/\.bats$//')

‎hack/select-e2e_test.bats‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,11 @@
111111
[ "$output" = "redis" ]
112112
}
113113

114-
@test "release-e2e workflow change triggers full suite" {
114+
@test "pull-requests workflow change triggers full suite" {
115115
tmp=$(mktemp -d)
116116
trap 'rm -rf "$tmp"' EXIT
117117
cp -r packages/core/platform/sources "$tmp/sources"
118-
echo ".github/workflows/release-e2e.yaml" > "$tmp/diff"
118+
echo ".github/workflows/pull-requests.yaml" > "$tmp/diff"
119119
output=$(hack/select-e2e.sh "$tmp/diff" "$tmp/sources")
120120
[ "$(echo "$output" | wc -w)" -gt 5 ]
121121
}

0 commit comments

Comments
 (0)