Repository navigation

Commit b09b44d

committed

feat(apps): mark stateful-app storageClass fields as immutable

Annotate storageClass as immutable across every stateful app whose chart exposes one — clickhouse, foundationdb, harbor, http-cache, kafka (Kafka + ZooKeeper), kubernetes (top-level only), mariadb, mongodb, nats, openbao, opensearch, postgres, qdrant, rabbitmq, redis, vm-disk. Without coverage across the catalogue the UI would render storageClass read-only on some apps and editable on others — a worse mental model than uniform behaviour. The annotation lands at the schema layer (CEL XValidation rule 'self == oldSelf' on values.schema.json / types.go / embedded openAPISchema in cozyrds/<app>.yaml). The cozystack aggregated apiserver does not yet evaluate CEL on application-backed resources; that is tracked at #2657. The UI (cozystack/cozystack-ui#6) consumes the marker today. The PVC-pinning argument is identical for every chart: Kubernetes fixes a PVC's storageClassName at creation time, so editing this field on an existing resource never migrated data. The schema annotation makes that contract explicit. kubernetes.nodeGroups[name].storageClass is intentionally NOT annotated: the field is optional and undefaulted, so a strict 'self == oldSelf' rule would block any future attempt to set it on an existing node group. A richer ratcheting form is needed there — see docs/storage-immutability.md. A refactor in pkg/registry/apps/application/rest.go extracts the inline schema-build path into buildSpecSchema so it can be unit-tested. Three regression tests in rest_spec_schema_test.go pin the contract that x-kubernetes-validations survives the v1->internal->structural conversion (loaded from the actual MariaDB ApplicationDefinition fixture on disk, not a hand-edited mock). Each per-app README gains a one-line blockquote pointing to a new docs/storage-immutability.md that explains the contract and which consumers enforce it today. Requires cozystack/cozyvalues-gen with @immutable support — bump the pre-commit pin in .github/workflows/pre-commit.yml once the release exists. Assisted-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>

1 parent cb2f606 commit b09b44dCopy full SHA for b09b44d

83 files changed

api/apps/v1alpha1
- clickhouse
  - types.go
- foundationdb
  - types.go
- harbor
  - types.go
- httpcache
  - types.go
- kafka
  - types.go
- kubernetes
  - types.go
- mariadb
  - types.go
- mongodb
  - types.go
- nats
  - types.go
- openbao
  - types.go
- opensearch
  - types.go
- postgresql
  - types.go
- qdrant
  - types.go
- rabbitmq
  - types.go
- redis
  - types.go
- vmdisk
  - types.go
docs
- storage-immutability.md
packages
- apps
  - clickhouse
  - foundationdb
  - harbor
  - http-cache
  - kafka
  - kubernetes
  - mariadb
  - mongodb
  - nats
  - openbao
  - opensearch
  - postgres
  - qdrant
  - rabbitmq
  - redis
  - vm-disk
- system
  - clickhouse-rd/cozyrds
    - clickhouse.yaml
  - foundationdb-rd/cozyrds
    - foundationdb.yaml
  - harbor-rd/cozyrds
    - harbor.yaml
  - http-cache-rd/cozyrds
    - http-cache.yaml
  - kafka-rd/cozyrds
    - kafka.yaml
  - kubernetes-rd/cozyrds
    - kubernetes.yaml
  - mariadb-rd/cozyrds
    - mariadb.yaml
  - mongodb-rd/cozyrds
    - mongodb.yaml
  - nats-rd/cozyrds
    - nats.yaml
  - openbao-rd/cozyrds
    - openbao.yaml
  - opensearch-rd/cozyrds
    - opensearch.yaml
  - postgres-rd/cozyrds
    - postgres.yaml
  - qdrant-rd/cozyrds
    - qdrant.yaml
  - rabbitmq-rd/cozyrds
    - rabbitmq.yaml
  - redis-rd/cozyrds
    - redis.yaml
  - vm-disk-rd/cozyrds
    - vm-disk.yaml
pkg/registry/apps/application
- rest.go
- rest_spec_schema_test.go

(0)

Navigation Menu

Repository navigation

Commit b09b44d

Some content is hidden

`‎api/apps/v1alpha1/clickhouse/types.go‎`

`‎api/apps/v1alpha1/foundationdb/types.go‎`

`‎api/apps/v1alpha1/harbor/types.go‎`

`‎api/apps/v1alpha1/httpcache/types.go‎`

`‎api/apps/v1alpha1/kafka/types.go‎`

`‎api/apps/v1alpha1/kubernetes/types.go‎`

`‎api/apps/v1alpha1/mariadb/types.go‎`

`‎api/apps/v1alpha1/mongodb/types.go‎`

`‎api/apps/v1alpha1/nats/types.go‎`

`‎api/apps/v1alpha1/openbao/types.go‎`

File tree

Some content is hidden

0 commit comments